Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

06479 - AddressBookInitializer do not validate state loaded addressbook #6480

Conversation

edward-swirldslabs
Copy link
Contributor

Closes #6479

Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@edward-swirldslabs edward-swirldslabs added this to the v0.39 milestone May 5, 2023
@edward-swirldslabs edward-swirldslabs self-assigned this May 5, 2023
@edward-swirldslabs edward-swirldslabs marked this pull request as ready for review May 5, 2023 18:12
@edward-swirldslabs edward-swirldslabs requested a review from a team as a code owner May 5, 2023 18:12
@github-actions
Copy link

github-actions bot commented May 5, 2023

Node: Unit Test Results

  1 358 files    1 358 suites   53m 4s ⏱️
97 568 tests 97 560 ✔️ 8 💤 0
99 199 runs  99 191 ✔️ 8 💤 0

Results for commit b3750cd.

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +91.00 🎉

Comparison is base (227c7cf) 0.00% compared to head (b3750cd) 91.00%.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #6480       +/-   ##
==============================================
+ Coverage           0   91.00%   +91.00%     
- Complexity         0    17374    +17374     
==============================================
  Files              0     1332     +1332     
  Lines              0    49881    +49881     
  Branches           0     5012     +5012     
==============================================
+ Hits               0    45395    +45395     
- Misses             0     3525     +3525     
- Partials           0      961      +961     

see 1332 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented May 5, 2023

Node: E2E Test Results

    1 files      1 suites   17m 23s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit b3750cd.

@github-actions
Copy link

github-actions bot commented May 5, 2023

Node: Integration Test Results

    3 files      3 suites   14m 52s ⏱️
151 tests 151 ✔️ 0 💤 0
152 runs  152 ✔️ 0 💤 0

Results for commit b3750cd.

@github-actions
Copy link

github-actions bot commented May 5, 2023

Platform: JUnit Test Report

     509 files           1 errors  508 suites   20m 3s ⏱️
13 644 tests 13 607 ✔️ 37 💤 0
15 428 runs  15 391 ✔️ 37 💤 0

Results for commit b3750cd.

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@edward-swirldslabs edward-swirldslabs merged commit 238dc6c into develop May 5, 2023
18 of 20 checks passed
@edward-swirldslabs edward-swirldslabs deleted the 06479-AddressBookInitializer-do-not-re-validate-state-address-book branch May 5, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddressBookInitializer - state address book should not be re-validated.
3 participants