Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick into v0.38 for 06479 - AddressBookInitializer skip validating state loaded addressbook #6481

Conversation

edward-swirldslabs
Copy link
Contributor

@edward-swirldslabs edward-swirldslabs commented May 5, 2023

Closes #6479
Prior Behavior:

  • During restarts that did not have a software upgrade, if the state loaded address book differed from the config.txt address book in any way other than stake values, the config.txt address book would be used with a warning.

New Behavior

  • During restarts that do not have a software upgrade, the state loaded address book is always used.

Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@edward-swirldslabs edward-swirldslabs added this to the v0.38 milestone May 5, 2023
@edward-swirldslabs edward-swirldslabs self-assigned this May 5, 2023
@edward-swirldslabs edward-swirldslabs changed the base branch from develop to release/0.38 May 5, 2023 18:22
@github-actions
Copy link

github-actions bot commented May 5, 2023

Node: Unit Test Results

  1 351 files    1 351 suites   1h 27m 23s ⏱️
97 505 tests 97 497 ✔️ 8 💤 0
99 137 runs  99 129 ✔️ 8 💤 0

Results for commit 8005c39.

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@edward-swirldslabs edward-swirldslabs marked this pull request as ready for review May 5, 2023 18:39
@edward-swirldslabs edward-swirldslabs requested a review from a team as a code owner May 5, 2023 18:39
@github-actions
Copy link

github-actions bot commented May 5, 2023

Node: Integration Test Results

    3 files      3 suites   15m 25s ⏱️
151 tests 151 ✔️ 0 💤 0
152 runs  152 ✔️ 0 💤 0

Results for commit 8005c39.

@github-actions
Copy link

github-actions bot commented May 5, 2023

Node: E2E Test Results

    1 files      1 suites   17m 10s ⏱️
309 tests 309 ✔️ 0 💤 0
327 runs  327 ✔️ 0 💤 0

Results for commit 8005c39.

@github-actions
Copy link

github-actions bot commented May 5, 2023

Platform: JUnit Test Report

     500 files           1 errors  499 suites   30m 9s ⏱️
13 581 tests 13 540 ✔️ 41 💤 0
15 364 runs  15 323 ✔️ 41 💤 0

Results for commit 8005c39.

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nathanklick nathanklick merged commit 33fa715 into release/0.38 May 5, 2023
19 of 31 checks passed
@nathanklick nathanklick deleted the 06479-release0.38-AddressBookInitializer-skip-validating-state-loaded-addressbook branch May 5, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddressBookInitializer - state address book should not be re-validated.
4 participants