Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

06516 flatten build event handlers #6517

Merged
merged 4 commits into from May 11, 2023
Merged

06516 flatten build event handlers #6517

merged 4 commits into from May 11, 2023
+85 −113

Conversation

cody-littley
Copy link
Contributor

Closes #6516

@cody-littley
Flatten SwirldsPlatform.buildEventHandlers()
ea2f117 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Flatten SwirldsPlatform.buildEventHandlers()
c2114cb 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley added this to the v0.39 milestone May 9, 2023
@cody-littley cody-littley self-assigned this May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023 •
edited

Node: Unit Test Results

  1 362 files    1 362 suites   1h 25m 36s ⏱️
97 612 tests 97 605 ✔️ 7 💤 0 ❌
99 243 runs  99 236 ✔️ 7 💤 0 ❌

Results for commit 5924a38.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented May 9, 2023

Node: E2E Test Results

    1 files      1 suites   17m 23s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
328 runs  328 ✔️ 0 💤 0 ❌

Results for commit c2114cb.

@github-actions
Copy link

github-actions bot commented May 9, 2023 •
edited

Node: Integration Test Results

    3 files      3 suites   13m 32s ⏱️
151 tests 151 ✔️ 0 💤 0 ❌
152 runs  152 ✔️ 0 💤 0 ❌

Results for commit 5924a38.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 9, 2023

Platform: JUnit Test Report

     509 files           1 errors  508 suites   20m 27s ⏱️
13 644 tests 13 607 ✔️ 37 💤 0 ❌
15 428 runs  15 391 ✔️ 37 💤 0 ❌

Results for commit c2114cb.

@cody-littley cody-littley marked this pull request as ready for review May 9, 2023 22:07
@cody-littley cody-littley requested review from a team as code owners May 9, 2023 22:07
artemananiev
artemananiev previously approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@artemananiev artemananiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from platform-data perspective

@cody-littley
Made suggested changes.
2279708 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@cody-littley cody-littley merged commit 7160e00 into develop May 11, 2023
16 of 18 checks passed
@cody-littley cody-littley deleted the 06516-flatten-build-event-handlers branch May 11, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alittley alittley alittley approved these changes

@hendrikebbers hendrikebbers hendrikebbers left review comments

@artemananiev artemananiev artemananiev left review comments

@edward-swirldslabs edward-swirldslabs Awaiting requested review from edward-swirldslabs edward-swirldslabs is a code owner automatically assigned from hashgraph/platform-hashgraph

@timo0 timo0 Awaiting requested review from timo0 timo0 is a code owner automatically assigned from hashgraph/platform-base

@lpetrovic05 lpetrovic05 Awaiting requested review from lpetrovic05

Assignees

@cody-littley cody-littley

Labels
None yet
Projects
None yet
Milestone
v0.39
Development

Successfully merging this pull request may close these issues.

Flatten SwirldsPlatform.buildEventHandlers()
4 participants
@cody-littley @hendrikebbers @artemananiev @alittley