Out of Order Gossip Simulator #6535

poulok · 2023-05-10T20:04:41Z

Description:
Introduces a new unit test based simulator for Out of Order Gossip and two unit tests showing how it can be used.

Related issue(s):

Fixes #6533
Fixed #6534

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

Signed-off-by: Kelly Greco <kelly@swirldslabs.com> # Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/SwirldsPlatform.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/GossipEvent.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/linking/OrphanBufferingLinker.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/validation/EventDeduplication.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/chatter/protocol/ChatterCore.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/chatter/protocol/messages/EventDescriptor.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/chatter/protocol/peer/PeerGossipState.java # platform-sdk/swirlds-unit-tests/core/swirlds-platform-test/src/main/java/com/swirlds/platform/test/chatter/EventDedup.java # platform-sdk/swirlds-unit-tests/core/swirlds-platform-test/src/main/java/com/swirlds/platform/test/chatter/simulator/EventTracker.java # platform-sdk/swirlds-unit-tests/core/swirlds-platform-test/src/main/java/com/swirlds/platform/test/simulated/SimulatedEventCreationNode.java # platform-sdk/swirlds-unit-tests/core/swirlds-platform-test/src/test/java/com/swirlds/platform/test/event/linking/OrphanBufferTester.java

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

github-actions · 2023-05-10T20:08:25Z

Node: Unit Test Results

    1 382 files     1 382 suites 1h 12m 55s ⏱️
  98 444 tests   98 437 ✔️ 7 💤 0 ❌
103 609 runs 103 602 ✔️ 7 💤 0 ❌

Results for commit a297050.

♻️ This comment has been updated with latest results.

github-actions · 2023-05-10T20:17:18Z

Node: E2E Test Results

    1 files     1 suites 17m 41s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
328 runs 328 ✔️ 0 💤 0 ❌

Results for commit a297050.

♻️ This comment has been updated with latest results.

github-actions · 2023-05-10T20:17:53Z

Node: Integration Test Results

    4 files     4 suites 13m 57s ⏱️
170 tests 170 ✔️ 0 💤 0 ❌
172 runs 172 ✔️ 0 💤 0 ❌

Results for commit a297050.

♻️ This comment has been updated with latest results.

github-actions · 2023-05-10T20:44:29Z

Platform: JUnit Test Report

    523 files         1 errors 522 suites 23m 39s ⏱️
13 821 tests 13 785 ✔️ 36 💤 0 ❌
15 806 runs 15 770 ✔️ 36 💤 0 ❌

Results for commit a297050.

♻️ This comment has been updated with latest results.

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

Signed-off-by: Kelly Greco <kelly@swirldslabs.com> # Conflicts: # platform-sdk/swirlds-unit-tests/core/swirlds-platform-test/src/main/java/com/swirlds/platform/test/simulated/SimulatedEventCreationNode.java

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

Signed-off-by: Kelly Greco <kelly@swirldslabs.com> # Conflicts: # platform-sdk/swirlds-unit-tests/core/swirlds-platform-test/src/main/java/com/swirlds/platform/test/simulated/SimulatedEventCreationNode.java

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

platform-sdk/swirlds-common/src/main/java/com/swirlds/common/utility/DurationUtils.java

...ore/src/main/java/com/swirlds/platform/gossip/chatter/protocol/messages/EventDescriptor.java

...e/swirlds-platform-test/src/main/java/com/swirlds/platform/test/simulated/GossipMessage.java

...test/src/test/java/com/swirlds/platform/test/chatter/network/framework/NodeConfigurable.java

...src/test/java/com/swirlds/platform/test/chatter/network/framework/SimulatedChatterEvent.java

...src/test/java/com/swirlds/platform/test/chatter/network/framework/SimulatedEventCreator.java

...rc/test/java/com/swirlds/platform/test/chatter/network/framework/SimulatedEventPipeline.java

.../java/com/swirlds/platform/test/chatter/network/framework/SimulatedEventPipelineBuilder.java

platform-sdk/swirlds-common/src/main/java/com/swirlds/common/utility/DurationUtils.java

...ds-platform-core/src/main/java/com/swirlds/platform/event/validation/EventDeduplication.java

...ore/src/main/java/com/swirlds/platform/gossip/chatter/protocol/messages/EventDescriptor.java

...rm-core/src/main/java/com/swirlds/platform/gossip/chatter/protocol/peer/PeerGossipState.java

...ds-platform-test/src/main/java/com/swirlds/platform/test/chatter/simulator/EventTracker.java

...e/swirlds-platform-test/src/main/java/com/swirlds/platform/test/simulated/GossipMessage.java

...ds-platform-test/src/main/java/com/swirlds/platform/test/simulated/GossipMessageHandler.java

...rlds-platform-test/src/main/java/com/swirlds/platform/test/simulated/config/ListBuilder.java

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

Signed-off-by: Kelly Greco <kelly@swirldslabs.com> # Conflicts: # platform-sdk/swirlds-unit-tests/core/swirlds-platform-test/src/main/java/com/swirlds/platform/test/simulated/SimpleSimulatedGossip.java # platform-sdk/swirlds-unit-tests/core/swirlds-platform-test/src/test/java/com/swirlds/platform/test/event/creation/EventCreationSimulationTest.java

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

codecov · 2023-05-17T13:19:18Z

Codecov Report

Patch coverage has no change and project coverage change: +90.72 🎉

Comparison is base (4b01b06) 0.00% compared to head (a297050) 90.72%.

Additional details and impacted files

@@              Coverage Diff               @@
##             develop    #6535       +/-   ##
==============================================
+ Coverage           0   90.72%   +90.72%     
- Complexity         0    17515    +17515     
==============================================
  Files              0     1389     +1389     
  Lines              0    50477    +50477     
  Branches           0     5091     +5091     
==============================================
+ Hits               0    45796    +45796     
- Misses             0     3710     +3710     
- Partials           0      971      +971

see 1389 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

sonarcloud · 2023-05-17T13:19:59Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarcloud · 2023-05-17T13:58:45Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
7 Code Smells

43.1% Coverage
0.0% Duplication

lpetrovic05

it a good start, but it will need more work in the future

...s-platform-test/src/main/java/com/swirlds/platform/test/simulated/SimpleSimulatedGossip.java

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

poulok and others added 11 commits February 28, 2023 14:19

port branch

3b09607

spotless formatting

1a05c89

Merge branch 'develop' into 06564-D-oog-sim-2

5123f94

lots of updates, fixes, refactors

fab770a

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

cleanup, javadocs

932aab5

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

spotless

5bbc749

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

javadocs

48326ed

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

javadoc

393d0a0

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

more javadoc

618c6ff

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

Merge branch 'develop' into 06533-D-oog-sim

d8a47aa

poulok added the CI:UnitTests label May 10, 2023

poulok added this to the v0.39 milestone May 10, 2023

poulok self-assigned this May 10, 2023

poulok changed the title ~~06533 d oog sim~~ Out of Order Gossip Simulator May 10, 2023

poulok added 3 commits May 11, 2023 14:39

add heartbeat interval configuration, misc other updates

fb14467

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

Merge branch 'develop' into 06533-D-oog-sim

50e9e2a

Signed-off-by: Kelly Greco <kelly@swirldslabs.com> # Conflicts: # platform-sdk/swirlds-unit-tests/core/swirlds-platform-test/src/main/java/com/swirlds/platform/test/simulated/SimulatedEventCreationNode.java

disable test

8cc1f32

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

poulok marked this pull request as ready for review May 12, 2023 15:49

poulok requested review from a team as code owners May 12, 2023 15:49

poulok requested review from lpetrovic05, timo0, deepak-swirlds and cody-littley May 12, 2023 15:50

poulok requested review from artemananiev and removed request for artemananiev May 12, 2023 15:50

poulok added 5 commits May 12, 2023 10:52

add final

7d553c5

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

Merge branch 'develop' into 06533-D-oog-sim

87c0de0

fix build

1f6830d

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

Merge branch 'develop' into 06533-D-oog-sim

84e4aeb

Signed-off-by: Kelly Greco <kelly@swirldslabs.com> # Conflicts: # platform-sdk/swirlds-unit-tests/core/swirlds-platform-test/src/main/java/com/swirlds/platform/test/simulated/SimulatedEventCreationNode.java

spotless

1ab18e1

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

cody-littley reviewed May 12, 2023

View reviewed changes

poulok mentioned this pull request May 12, 2023

Improve simulated gossip/internet performance #6580

Closed

hendrikebbers reviewed May 15, 2023

View reviewed changes

poulok added 6 commits May 15, 2023 08:14

reviewer comments

5293e15

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

Merge branch 'develop' into 06533-D-oog-sim

7aaf4d2

reviewer comments, use NodeId

c025b7c

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

Merge branch 'develop' into 06533-D-oog-sim

9633ba2

fix unit tests

a297050

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

poulok requested review from cody-littley and hendrikebbers May 17, 2023 13:11

poulok added CI:FinalChecks and removed CI:UnitTests labels May 17, 2023

lpetrovic05 approved these changes May 18, 2023

View reviewed changes

hendrikebbers approved these changes May 18, 2023

View reviewed changes

cody-littley approved these changes May 18, 2023

View reviewed changes

...s-platform-test/src/main/java/com/swirlds/platform/test/simulated/SimpleSimulatedGossip.java Show resolved Hide resolved

nathanklick merged commit ba89606 into develop May 18, 2023
38 of 41 checks passed

nathanklick deleted the 06533-D-oog-sim branch May 18, 2023 18:29

nickpoorman pushed a commit that referenced this pull request May 18, 2023

Out of Order Gossip Simulator (#6535)

9239498

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

iwsimon pushed a commit that referenced this pull request May 19, 2023

Out of Order Gossip Simulator (#6535)

9f1a8e0

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Out of Order Gossip Simulator #6535

Out of Order Gossip Simulator #6535

poulok commented May 10, 2023 •

edited

Loading

github-actions bot commented May 10, 2023 •

edited

Loading

github-actions bot commented May 10, 2023 •

edited

Loading

github-actions bot commented May 10, 2023 •

edited

Loading

github-actions bot commented May 10, 2023 •

edited

Loading

codecov bot commented May 17, 2023

sonarcloud bot commented May 17, 2023

sonarcloud bot commented May 17, 2023

lpetrovic05 left a comment

Out of Order Gossip Simulator #6535

Out of Order Gossip Simulator #6535

Conversation

poulok commented May 10, 2023 • edited Loading

github-actions bot commented May 10, 2023 • edited Loading

Node: Unit Test Results

github-actions bot commented May 10, 2023 • edited Loading

Node: E2E Test Results

github-actions bot commented May 10, 2023 • edited Loading

Node: Integration Test Results

github-actions bot commented May 10, 2023 • edited Loading

Platform: JUnit Test Report

codecov bot commented May 17, 2023

Codecov Report

sonarcloud bot commented May 17, 2023

sonarcloud bot commented May 17, 2023

lpetrovic05 left a comment

Choose a reason for hiding this comment

poulok commented May 10, 2023 •

edited

Loading

github-actions bot commented May 10, 2023 •

edited

Loading

github-actions bot commented May 10, 2023 •

edited

Loading

github-actions bot commented May 10, 2023 •

edited

Loading

github-actions bot commented May 10, 2023 •

edited

Loading