Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

06601 6518 remove get events #6602

Merged
merged 31 commits into from May 16, 2023
Merged

06601 6518 remove get events #6602

merged 31 commits into from May 16, 2023
+48 −92

Conversation

cody-littley
Copy link
Contributor

Closes #6601

@cody-littley
Flatten SwirldsPlatform.buildEventHandlers()
ea2f117 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Flatten SwirldsPlatform.buildEventHandlers()
c2114cb 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Started work refactoring PlatformMetrics
9bbc3b2 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental improvements.
6790f0d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
More progress.
2bb5dc5 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
IT'S GONE!
584b13a 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Cleanup.
8f6737c 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested changes.
2279708 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch '06516-flatten-build-event-handlers' into 06518-6516-del…
0b620af 
…ete-platform-metrics

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 06518-6516-delete-platform-metrics
81bbbbc 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Removed many getters from SwirldsPlatform
edc629f 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Removed getParameters()
40a1930 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Remove sleep after sync methods.
bf555f3 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Remove more methods.
5e35177 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Removed more getters.
ad7315c 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Removed getLastSignedStateTimestamp()
e37b788 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Removed even more methods.
91993d7 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
cleanup
727e71d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 6548-6518-remove-getters
4001a9d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fixed smells.
21e057f 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 6548-6518-remove-getters
7efcaf1 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested change.
8487e88 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested changes.
bba897c 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested change.
ffb11ea 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Make suggested changes.
21642b4 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested changes.
5c82c01 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Move GUI code for getting all events out of the platform.
ac5ea3f 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley self-assigned this May 15, 2023
@cody-littley cody-littley changed the base branch from develop to 6548-6518-remove-getters May 15, 2023 17:58
@github-actions
Copy link

github-actions bot commented May 15, 2023 •
edited

Node: Integration Test Results

    3 files      3 suites   13m 44s ⏱️
151 tests 151 ✔️ 0 💤 0 ❌
153 runs  153 ✔️ 0 💤 0 ❌

Results for commit 7b37ecc.

♻️ This comment has been updated with latest results.

Base automatically changed from 6548-6518-remove-getters to develop May 15, 2023 18:12
@github-actions
Copy link

github-actions bot commented May 15, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   17m 22s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
328 runs  328 ✔️ 0 💤 0 ❌

Results for commit 7b37ecc.

♻️ This comment has been updated with latest results.

@cody-littley
Merge branch 'develop' into 06601-6518-remove-get-events
5cc178d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley marked this pull request as ready for review May 15, 2023 18:30
@cody-littley cody-littley requested review from a team as code owners May 15, 2023 18:30
alittley
alittley previously approved these changes May 15, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented May 15, 2023 •
edited

Platform: JUnit Test Report

     512 files           1 errors  511 suites   20m 11s ⏱️
13 651 tests 13 617 ✔️ 34 💤 0 ❌
15 435 runs  15 401 ✔️ 34 💤 0 ❌

Results for commit 7b37ecc.

♻️ This comment has been updated with latest results.

@cody-littley
Merge branch 'develop' into 06601-6518-remove-get-events
5679323 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
hendrikebbers
hendrikebbers previously approved these changes May 16, 2023
View reviewed changes
@cody-littley
Fixed comile issue.
9106887 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
alittley
alittley previously approved these changes May 16, 2023
View reviewed changes
@cody-littley
Fixed broken test.
7b37ecc 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@cody-littley cody-littley merged commit 9fe8b07 into develop May 16, 2023
21 of 23 checks passed
@cody-littley cody-littley deleted the 06601-6518-remove-get-events branch May 16, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edward-swirldslabs edward-swirldslabs edward-swirldslabs approved these changes

@hendrikebbers hendrikebbers hendrikebbers left review comments

@alittley alittley alittley left review comments

@poulok poulok Awaiting requested review from poulok poulok is a code owner automatically assigned from hashgraph/platform-hashgraph

@timo0 timo0 Awaiting requested review from timo0 timo0 is a code owner automatically assigned from hashgraph/platform-base

@artemananiev artemananiev Awaiting requested review from artemananiev artemananiev is a code owner automatically assigned from hashgraph/platform-data

Assignees

@cody-littley cody-littley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unsafe getAllEvents() method from SwirldsPlatform
4 participants
@cody-littley @hendrikebbers @alittley @edward-swirldslabs