Bytes Converter added for Config #6643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikebbers
requested review from
tomzhenghedera,
nathanklick,
nickpoorman and
netopyr
mhess-swl
previously approved these changes
May 24, 2023
jsync-swirlds
force-pushed
the
6642-bytes-converter
branch
from
612604c
to
3e2f2ae
Compare
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
jsync-swirlds
force-pushed
the
6642-bytes-converter
branch
from
3e2f2ae
to
e447a2b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #6643 +/- ##
==============================================
+ Coverage 67.74% 89.74% +22.00%
+ Complexity 22834 17792 -5042
==============================================
Files 2126 1418 -708
Lines 138924 52085 -86839
Branches 7971 5285 -2686
==============================================
- Hits 94117 46745 -47372
+ Misses 43231 4311 -38920
+ Partials 1576 1029 -547
☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed! |
JeffreyDallas
approved these changes
May 26, 2023
rbair23
reviewed
May 26, 2023
| } else { | ||
| try { | ||
| final var hex = value.substring(2); | ||
| final var bytes = unhex(hex); |
There was a problem hiding this comment.
rbair23
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #6642