Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes Converter added for Config #6643

Merged
merged 1 commit into from May 26, 2023
Merged

Conversation

hendrikebbers
Copy link
Member

fix for #6642

@github-actions
Copy link

github-actions bot commented May 24, 2023

Node: Unit Test Results

    1 412 files      1 412 suites   16m 34s ⏱️
100 332 tests 100 325 ✔️ 7 💤 0
106 670 runs  106 663 ✔️ 7 💤 0

Results for commit e447a2b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 24, 2023

Node: Integration Test Results

    4 files      4 suites   13m 50s ⏱️
170 tests 170 ✔️ 0 💤 0
172 runs  172 ✔️ 0 💤 0

Results for commit e447a2b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 24, 2023

Node: E2E Test Results

    1 files      1 suites   18m 12s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit e447a2b.

♻️ This comment has been updated with latest results.

mhess-swl
mhess-swl previously approved these changes May 24, 2023
iwsimon
iwsimon previously approved these changes May 25, 2023
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +22.00 🎉

Comparison is base (756c025) 67.74% compared to head (e447a2b) 89.74%.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #6643       +/-   ##
==============================================
+ Coverage      67.74%   89.74%   +22.00%     
+ Complexity     22834    17792     -5042     
==============================================
  Files           2126     1418      -708     
  Lines         138924    52085    -86839     
  Branches        7971     5285     -2686     
==============================================
- Hits           94117    46745    -47372     
+ Misses         43231     4311    -38920     
+ Partials        1576     1029      -547     
Impacted Files Coverage Δ
...com/hedera/node/app/config/ConfigProviderImpl.java 90.99% <100.00%> (+0.08%) ⬆️
...m/hedera/node/config/converter/BytesConverter.java 100.00% <100.00%> (ø)

... and 944 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jsync-swirlds jsync-swirlds merged commit 06dd0da into develop May 26, 2023
17 of 18 checks passed
@jsync-swirlds jsync-swirlds deleted the 6642-bytes-converter branch May 26, 2023 16:34
} else {
try {
final var hex = value.substring(2);
final var bytes = unhex(hex);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants