Implement complete SubmissionManager with expiry dedupe cache #6646
+271
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Bair <rbair23@users.noreply.github.com>
Signed-off-by: Richard Bair <rbair23@users.noreply.github.com>
Signed-off-by: Richard Bair <rbair23@users.noreply.github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #6646 +/- ##
==============================================
+ Coverage 67.93% 90.73% +22.79%
+ Complexity 22545 17524 -5021
==============================================
Files 2092 1390 -702
Lines 137030 50501 -86529
Branches 7788 5093 -2695
==============================================
- Hits 93088 45820 -47268
+ Misses 42424 3711 -38713
+ Partials 1518 970 -548
☔ View full report in Codecov by Sentry. |
|
SonarCloud Quality Gate failed. |
nickpoorman
pushed a commit
that referenced
this pull request
May 18, 2023
Signed-off-by: Richard Bair <rbair23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6636
SubmissionManagercan ignore theRecordCacheand have its own expiry cache. This makes it really easy to understand the behavior of the system and nullifies some potential problems with dishonest nodes. Most importantly, the question theSubmissionManagerhas to answer is "Have I seen this transaction ID submitted to me already?". It needs to answer this question because the node does not want to submit duplicate transactions (since if it does, it has to pay for it). It doesn't need to know anything about what transactions other nodes have seen or what the ultimate resolution of a transaction is. It just needs to say "within the valid transaction ID lifespan, have I seen this transaction submitted by a user before"? This allows us to keep the implementation very simple and decoupled from theRecordCache.