Added comment that hashCode test values must not be changed #6647
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...no-service/src/test/java/com/hedera/node/app/service/mono/state/virtual/ContractKeyTest.java
Outdated
Show resolved
Hide resolved
nickpoorman
requested review from
a team,
mhess-swl and
Neeharika-Sompalli
as code owners
nickpoorman
requested review from
mattp-swirldslabs,
nathanklick,
poulok,
timo0 and
artemananiev
nickpoorman
force-pushed
the
fix-6581
branch
2 times, most recently
from
596548f
to
ae0bc9b
Compare
mhess-swl
approved these changes
May 18, 2023
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: We recently copied the hashCode function from Platform into Services. We need to ensure that the result of this hash code never changes or risk data ending up in a corrupted state, (under incorrect keys).
Fixes #6581