06651 Added missing rehash for VirtualMap leaves #6653
Merged
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imalygin
force-pushed
the
06651-test-failure-due-to-missing-hashes
branch
2 times, most recently
from
49d3a92
to
a01c317
Compare
imalygin
force-pushed
the
06651-test-failure-due-to-missing-hashes
branch
from
a01c317
to
c786bf4
Compare
cody-littley
previously approved these changes
May 18, 2023
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
imalygin
force-pushed
the
06651-test-failure-due-to-missing-hashes
branch
from
c786bf4
to
1afb9ab
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
cody-littley
approved these changes
May 18, 2023
JeffreyDallas
approved these changes
May 18, 2023
nickpoorman
pushed a commit
that referenced
this pull request
May 18, 2023
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
iwsimon
pushed a commit
that referenced
this pull request
May 19, 2023
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds
fullLeafRehashcall toVirtualMapinstances created byVirtualMerkleStateInitializerinPlatformTestingToolRelated issue(s):
Fixes #6651
Notes for reviewer:
This test should fix https://github.com/swirlds/swirlds-platform-regression/issues/3411