New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CryptoDelete handle implementation #6694
Conversation
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #6694 +/- ##
==============================================
+ Coverage 67.91% 89.72% +21.80%
+ Complexity 22849 17813 -5036
==============================================
Files 2126 1419 -707
Lines 138924 52160 -86764
Branches 7970 5293 -2677
==============================================
- Hits 94353 46799 -47554
+ Misses 42998 4325 -38673
+ Partials 1573 1036 -537
☔ View full report in Codecov by Sentry. |
...ra-node/hedera-app-spi/src/main/java/com/hedera/node/app/spi/validation/ExpiryValidator.java
Outdated
Show resolved
Hide resolved
...main/java/com/hedera/node/app/service/token/impl/handlers/TokenFeeScheduleUpdateHandler.java
Outdated
Show resolved
Hide resolved
.../test/java/com/hedera/node/app/service/token/impl/test/handlers/CryptoDeleteHandlerTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/hedera/node/app/service/token/impl/test/handlers/CryptoHandlerTestBase.java
Outdated
Show resolved
Hide resolved
...st/java/com/hedera/node/app/service/token/impl/test/handlers/CryptoTokenHandlerTestBase.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/hedera/node/app/workflows/handle/validation/StandardizedExpiryValidator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
...ra-node/hedera-app-spi/src/main/java/com/hedera/node/app/spi/validation/ExpiryValidator.java
Show resolved
Hide resolved
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please post test result if
the change impacts any nightly regress panels
@JeffreyDallas This is all new code, doesn't affect any existing tests. |
Fixes #6393
Fixes #6410
CryptoDelete
handle implementationTokensConfig
instead ofTokenServiceConfig