Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CryptoDelete handle implementation #6694

Merged
merged 21 commits into from May 26, 2023
Merged

Conversation

Neeharika-Sompalli
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli commented May 19, 2023

Fixes #6393
Fixes #6410

  • Adds CryptoDelete handle implementation
  • Uses TokensConfig instead of TokenServiceConfig

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented May 19, 2023

Node: Unit Test Results

    1 411 files      1 411 suites   20m 0s ⏱️
100 331 tests 100 324 ✔️ 7 💤 0
106 669 runs  106 662 ✔️ 7 💤 0

Results for commit 4f1a638.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 19, 2023

Node: Integration Test Results

    4 files      4 suites   13m 41s ⏱️
170 tests 170 ✔️ 0 💤 0
172 runs  172 ✔️ 0 💤 0

Results for commit 4f1a638.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 19, 2023

Node: E2E Test Results

    1 files      1 suites   19m 38s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit 4f1a638.

♻️ This comment has been updated with latest results.

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@Neeharika-Sompalli Neeharika-Sompalli self-assigned this May 21, 2023
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@Neeharika-Sompalli Neeharika-Sompalli marked this pull request as ready for review May 21, 2023 14:49
@Neeharika-Sompalli Neeharika-Sompalli requested review from a team and mhess-swl as code owners May 21, 2023 14:49
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage: 73.86% and project coverage change: +21.80 🎉

Comparison is base (698243f) 67.91% compared to head (4f1a638) 89.72%.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #6694       +/-   ##
==============================================
+ Coverage      67.91%   89.72%   +21.80%     
+ Complexity     22849    17813     -5036     
==============================================
  Files           2126     1419      -707     
  Lines         138924    52160    -86764     
  Branches        7970     5293     -2677     
==============================================
- Hits           94353    46799    -47554     
+ Misses         42998     4325    -38673     
+ Partials        1573     1036      -537     
Impacted Files Coverage Δ
...com/hedera/node/app/spi/validation/EntityType.java 0.00% <0.00%> (ø)
...edera/node/app/spi/validation/ExpiryValidator.java 0.00% <0.00%> (ø)
...rkflows/handle/validation/MonoExpiryValidator.java 100.00% <ø> (ø)
...a/com/hedera/node/config/data/AutoRenewConfig.java 0.00% <0.00%> (ø)
...e/app/service/token/impl/WritableAccountStore.java 85.29% <0.00%> (-5.34%) ⬇️
...handle/validation/StandardizedExpiryValidator.java 90.38% <70.00%> (-4.97%) ⬇️
...rvice/token/impl/handlers/CryptoDeleteHandler.java 93.65% <92.59%> (+3.65%) ⬆️
...orkflows/dispatcher/MonoTransactionDispatcher.java 99.30% <100.00%> (+0.04%) ⬆️

... and 946 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
mhess-swl
mhess-swl previously approved these changes May 25, 2023
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
mhess-swl
mhess-swl previously approved these changes May 25, 2023
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

78.8% 78.8% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@JeffreyDallas JeffreyDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please post test result if
the change impacts any nightly regress panels

@Neeharika-Sompalli
Copy link
Member Author

please post test result if the change impacts any nightly regress panels

@JeffreyDallas This is all new code, doesn't affect any existing tests.

@Neeharika-Sompalli Neeharika-Sompalli merged commit 8b5431c into develop May 26, 2023
16 of 18 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the 6393-D-crypto-delete branch May 26, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants