New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pureChecks()
method to TransactionHandler
#6697
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #6697 +/- ##
==============================================
+ Coverage 68.05% 90.72% +22.66%
+ Complexity 22736 17696 -5040
==============================================
Files 2111 1408 -703
Lines 137666 51054 -86612
Branches 7861 5169 -2692
==============================================
- Hits 93694 46320 -47374
+ Misses 42421 3729 -38692
+ Partials 1551 1005 -546
☔ View full report in Codecov by Sentry. |
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Neeharika-Sompalli
requested review from
a team,
mhess-swl,
tinker-michaelj,
iwsimon,
kimbor and
povolev15
as code owners
May 22, 2023 17:11
netopyr
reviewed
May 22, 2023
...-node/hedera-app-spi/src/main/java/com/hedera/node/app/spi/workflows/TransactionHandler.java
Outdated
Show resolved
Hide resolved
rbair23
previously approved these changes
May 22, 2023
...in/java/com/hedera/node/app/service/consensus/impl/handlers/ConsensusDeleteTopicHandler.java
Outdated
Show resolved
Hide resolved
mhess-swl
reviewed
May 22, 2023
...-node/hedera-app-spi/src/main/java/com/hedera/node/app/spi/workflows/TransactionHandler.java
Show resolved
Hide resolved
mhess-swl
reviewed
May 22, 2023
...src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenFreezeAccountHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Neeharika-Sompalli
requested review from
netopyr,
mhess-swl,
jsync-swirlds and
rbair23
May 23, 2023 03:27
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
SonarCloud Quality Gate failed. |
...-impl/src/main/java/com/hedera/node/app/service/token/impl/handlers/CryptoCreateHandler.java
Show resolved
Hide resolved
...a-node/hedera-app-spi/src/main/java/com/hedera/node/app/spi/workflows/PreCheckException.java
Show resolved
Hide resolved
jsync-swirlds
approved these changes
May 23, 2023
mhess-swl
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
pureChecks()
method to TransactionHandler and implement in handlers