Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pureChecks() method to TransactionHandler #6697

Merged
merged 9 commits into from May 23, 2023

Conversation

Neeharika-Sompalli
Copy link
Member

Add pureChecks() method to TransactionHandler and implement in handlers

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented May 21, 2023

Node: Integration Test Results

    4 files      4 suites   13m 54s ⏱️
170 tests 170 ✔️ 0 💤 0
172 runs  172 ✔️ 0 💤 0

Results for commit 28c271b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 21, 2023

Node: E2E Test Results

    1 files      1 suites   18m 10s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit 28c271b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 21, 2023

Node: Unit Test Results

    1 408 files      1 408 suites   1h 17m 43s ⏱️
  98 607 tests   98 600 ✔️ 7 💤 0
103 772 runs  103 765 ✔️ 7 💤 0

Results for commit 28c271b.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: +22.66 🎉

Comparison is base (a92eb10) 68.05% compared to head (28c271b) 90.72%.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #6697       +/-   ##
==============================================
+ Coverage      68.05%   90.72%   +22.66%     
+ Complexity     22736    17696     -5040     
==============================================
  Files           2111     1408      -703     
  Lines         137666    51054    -86612     
  Branches        7861     5169     -2692     
==============================================
- Hits           93694    46320    -47374     
+ Misses         42421     3729    -38692     
+ Partials        1551     1005      -546     
Impacted Files Coverage Δ
...dera/node/app/spi/workflows/PreCheckException.java 36.36% <ø> (-43.64%) ⬇️
...era/node/app/spi/workflows/TransactionHandler.java 50.00% <0.00%> (-50.00%) ⬇️
...rvice/token/impl/handlers/CryptoCreateHandler.java 87.83% <90.90%> (-0.33%) ⬇️
...n/impl/handlers/TokenFeeScheduleUpdateHandler.java 100.00% <100.00%> (ø)
...token/impl/handlers/TokenFreezeAccountHandler.java 97.29% <100.00%> (+0.07%) ⬆️
...n/impl/handlers/TokenGrantKycToAccountHandler.java 93.33% <100.00%> (+0.22%) ⬆️
...mpl/handlers/TokenRevokeKycFromAccountHandler.java 100.00% <100.00%> (ø)
...ken/impl/handlers/TokenUnfreezeAccountHandler.java 100.00% <100.00%> (ø)

... and 943 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
rbair23
rbair23 previously approved these changes May 22, 2023
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.5% 80.5% Coverage
0.0% 0.0% Duplication

@Neeharika-Sompalli Neeharika-Sompalli merged commit 28c2179 into develop May 23, 2023
16 of 18 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the add-pure-checks branch May 23, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants