Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file service system file delete and undelete #6707

Merged
merged 8 commits into from
May 24, 2023

Conversation

povolev15
Copy link
Contributor

Implemented System delete and undelete pre handler, handler and tests

Related issue(s):

Fixes #6149 #6150

…d some changes to delte file as well.

Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@povolev15 povolev15 force-pushed the 6149-6150-File-Service-System-File-Delete-Undelete branch from feb75c5 to 20ddf0d Compare May 22, 2023 16:28
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented May 22, 2023

Node: Unit Test Results

    1 410 files      1 410 suites   1h 18m 28s ⏱️
  98 628 tests   98 621 ✔️ 7 💤 0
103 793 runs  103 786 ✔️ 7 💤 0

Results for commit c7b9f10.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 80.51% and project coverage change: +22.67 🎉

Comparison is base (a92eb10) 68.05% compared to head (c9ab5bb) 90.73%.

❗ Current head c9ab5bb differs from pull request most recent head c7b9f10. Consider uploading reports for the commit c7b9f10 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #6707       +/-   ##
==============================================
+ Coverage      68.05%   90.73%   +22.67%     
+ Complexity     22736    17716     -5020     
==============================================
  Files           2111     1408      -703     
  Lines         137666    51115    -86551     
  Branches        7861     5174     -2687     
==============================================
- Hits           93694    46381    -47313     
+ Misses         42421     3723    -38698     
+ Partials        1551     1011      -540     
Impacted Files Coverage Δ
...java/com/hedera/node/config/data/LedgerConfig.java 0.00% <ø> (ø)
.../service/file/impl/handlers/FileAppendHandler.java 72.50% <0.00%> (ø)
.../service/file/impl/handlers/FileCreateHandler.java 95.12% <ø> (ø)
.../service/file/impl/handlers/FileUpdateHandler.java 84.78% <0.00%> (ø)
.../service/file/impl/handlers/FileDeleteHandler.java 77.41% <60.00%> (-5.34%) ⬇️
.../app/service/file/impl/utils/FileServiceUtils.java 62.50% <68.75%> (+6.25%) ⬆️
.../file/impl/handlers/FileSystemUndeleteHandler.java 86.20% <88.00%> (+86.20%) ⬆️
...ce/file/impl/handlers/FileSystemDeleteHandler.java 87.09% <88.88%> (+87.09%) ⬆️
...e/app/service/file/impl/WritableFileStoreImpl.java 73.33% <100.00%> (+6.66%) ⬆️

... and 944 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented May 22, 2023

Node: Integration Test Results

    4 files      4 suites   13m 23s ⏱️
170 tests 170 ✔️ 0 💤 0
172 runs  172 ✔️ 0 💤 0

Results for commit c7b9f10.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 22, 2023

Node: E2E Test Results

    1 files      1 suites   18m 17s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit c7b9f10.

♻️ This comment has been updated with latest results.

@povolev15 povolev15 force-pushed the 6149-6150-File-Service-System-File-Delete-Undelete branch from 66a84d7 to d3fe698 Compare May 22, 2023 23:14
@povolev15 povolev15 requested a review from kimbor May 23, 2023 17:39
kimbor
kimbor previously approved these changes May 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

85.4% 85.4% Coverage
0.0% 0.0% Duplication

@povolev15 povolev15 merged commit 4caa89b into develop May 24, 2023
12 of 14 checks passed
@povolev15 povolev15 deleted the 6149-6150-File-Service-System-File-Delete-Undelete branch May 24, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

systemDelete - preHandle
6 participants