Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config sources for services defined #6743

Merged
merged 8 commits into from May 25, 2023

Conversation

hendrikebbers
Copy link
Member

See #5995

Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers hendrikebbers self-assigned this May 24, 2023
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
…s' into 5995-d-config-source-for-services

# Conflicts:
#	settings.gradle.kts
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@github-actions
Copy link

github-actions bot commented May 24, 2023

Node: Unit Test Results

    1 408 files      1 408 suites   1h 17m 44s ⏱️
  98 624 tests   98 617 ✔️ 7 💤 0
103 789 runs  103 782 ✔️ 7 💤 0

Results for commit aed96ec.

♻️ This comment has been updated with latest results.

Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@github-actions
Copy link

github-actions bot commented May 24, 2023

Node: Integration Test Results

    4 files      4 suites   13m 43s ⏱️
170 tests 170 ✔️ 0 💤 0
172 runs  172 ✔️ 0 💤 0

Results for commit aed96ec.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 24, 2023

Node: E2E Test Results

    1 files      1 suites   18m 22s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit aed96ec.

♻️ This comment has been updated with latest results.

@hendrikebbers hendrikebbers marked this pull request as ready for review May 24, 2023 13:08
@hendrikebbers hendrikebbers requested review from a team as code owners May 24, 2023 13:08
Copy link
Contributor

@jeromy-cannon jeromy-cannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a release engineering perspective I approve the build changes, please wait for other approvers for remaining code before merging.

Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.5% 72.5% Coverage
0.0% 0.0% Duplication

@hendrikebbers hendrikebbers merged commit c89af15 into develop May 25, 2023
14 of 16 checks passed
@hendrikebbers hendrikebbers deleted the 5995-d-config-source-for-services branch May 25, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants