New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
06788 Better handling of failed async hashing #6796
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemananiev
previously approved these changes
May 25, 2023
imalygin
force-pushed
the
06788-better-exception-handling
branch
2 times, most recently
from
May 25, 2023 20:36
8381557
to
5576de7
Compare
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
imalygin
force-pushed
the
06788-better-exception-handling
branch
from
May 25, 2023 20:39
5576de7
to
d14a054
Compare
OlegMazurov
previously approved these changes
May 25, 2023
artemananiev
previously approved these changes
May 25, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #6796 +/- ##
==============================================
+ Coverage 67.90% 89.74% +21.83%
+ Complexity 22849 17788 -5061
==============================================
Files 2126 1417 -709
Lines 138924 52074 -86850
Branches 7970 5283 -2687
==============================================
- Hits 94337 46734 -47603
+ Misses 43015 4311 -38704
+ Partials 1572 1029 -543 ☔ View full report in Codecov by Sentry. |
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/merkle/utility/MerkleUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Kudos, SonarCloud Quality Gate passed! |
artemananiev
approved these changes
May 26, 2023
SonarCloud Quality Gate failed. |
OlegMazurov
approved these changes
May 26, 2023
cody-littley
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently the exception is handled this way in MerkleUtils#rehashTree:
So, if any exception happens during the hashing, the stacktrace is lost.
This exception must not be swallowed. It should do two things:
Log the exception it caught
Rethrow the ExecutionException wrapped in some unchecked exception
Related issue(s):
Fixes #6788
Checklist