Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7135: ISS in account store after migration to disk (0.39) #7136

Merged
merged 2 commits into from Jun 16, 2023

Conversation

artemananiev
Copy link
Member

Fixes: #7135 (backport of #7087 to 0.39)
Signed-off-by: Artem Ananev artem.ananev@swirldslabs.com

Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
@artemananiev artemananiev added CI:UnitTests P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Jun 15, 2023
@artemananiev artemananiev added this to the v0.39 milestone Jun 15, 2023
@artemananiev artemananiev requested a review from a team as a code owner June 15, 2023 18:59
@artemananiev artemananiev self-assigned this Jun 15, 2023
@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Node: Unit Test Results

    1 423 files      1 423 suites   22m 36s ⏱️
100 452 tests 100 444 ✔️ 8 💤 0
106 805 runs  106 797 ✔️ 8 💤 0

Results for commit 528b161.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: +22.26 🎉

Comparison is base (9e999ef) 67.96% compared to head (528b161) 90.23%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             release/0.39    #7136       +/-   ##
===================================================
+ Coverage           67.96%   90.23%   +22.26%     
+ Complexity          23090    17941     -5149     
===================================================
  Files                2159     1423      -736     
  Lines              140009    52236    -87773     
  Branches             8000     5303     -2697     
===================================================
- Hits                95157    47134    -48023     
+ Misses              43260     4062    -39198     
+ Partials             1592     1040      -552     
Impacted Files Coverage Δ
...ice/mono/state/virtual/entities/OnDiskAccount.java 92.43% <25.00%> (-0.74%) ⬇️

... and 972 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Node: E2E Test Results

    1 files      1 suites   18m 18s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit 528b161.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Node: Integration Test Results

    4 files      4 suites   27m 43s ⏱️
262 tests 262 ✔️ 0 💤 0
264 runs  264 ✔️ 0 💤 0

Results for commit 528b161.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@artemananiev artemananiev linked an issue Jun 16, 2023 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@SimiHunjan SimiHunjan merged commit dd0c9e8 into release/0.39 Jun 16, 2023
16 of 18 checks passed
@SimiHunjan SimiHunjan deleted the 07135-039-accountondisk-copy-iss branch June 16, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 An issue impacting production environments or impacting multiple releases or multiple individuals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISS in account store after migration to disk (0.39)
4 participants