Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated contract nonces design doc #7331

Merged
merged 3 commits into from Aug 21, 2023

Conversation

agadzhalov
Copy link
Contributor

@agadzhalov agadzhalov commented Jun 29, 2023

Description:

Describe and update on how contract nonces are stored in state and how contract nonce externalization works.

Related issue(s):

Fixes #7126

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Alexander Gadzhalov <alexander.gadzhalov@limechain.tech>
@agadzhalov agadzhalov added the Limechain Work planned for the LimeChain team label Jun 29, 2023
@agadzhalov agadzhalov requested a review from a team as a code owner June 29, 2023 15:04
@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Node: E2E Test Results

    1 files      1 suites   18m 0s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit 841f748.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Node: Integration Test Results

278 tests   278 ✔️  32m 21s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 841f748.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Node: Unit Test Results

    1 612 files      1 612 suites   13m 12s ⏱️
103 556 tests 103 547 ✔️ 9 💤 0
109 953 runs  109 944 ✔️ 9 💤 0

Results for commit 841f748.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@4c216ab). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #7331   +/-   ##
==========================================
  Coverage           ?   87.84%           
  Complexity         ?    20450           
==========================================
  Files              ?     1629           
  Lines              ?    62567           
  Branches           ?     6626           
==========================================
  Hits               ?    54962           
  Misses             ?     6134           
  Partials           ?     1471           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

agadzhalov and others added 2 commits August 16, 2023 14:02
Signed-off-by: Alexander Gadzhalov <alexander.gadzhalov@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@agadzhalov agadzhalov merged commit 3e96d21 into develop Aug 21, 2023
12 checks passed
@agadzhalov agadzhalov deleted the 07126-update-contract-nonces-design-doc branch August 21, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HIP's design doc
4 participants