Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

07577 - Fix Uncaught Exception In Platform Core Unit Tests #7753

Merged
merged 1 commit into from Aug 2, 2023
Merged

07577 - Fix Uncaught Exception In Platform Core Unit Tests #7753

merged 1 commit into from Aug 2, 2023

Conversation

edward-swirldslabs
Copy link
Contributor

Fixes #7577

@edward-swirldslabs edward-swirldslabs added this to the v0.42 milestone Jul 31, 2023
@edward-swirldslabs edward-swirldslabs self-assigned this Jul 31, 2023
@github-actions
Copy link

github-actions bot commented Jul 31, 2023 •
edited

Node: Unit Test Results

    1 573 files      1 573 suites   15m 40s ⏱️
103 013 tests 103 001 ✔️ 12 💤 0 ❌
109 413 runs  109 401 ✔️ 12 💤 0 ❌

Results for commit c17195e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 31, 2023 •
edited

Node: Integration Test Results

277 tests   277 ✔️  32m 22s ⏱️
    5 suites      0 💤
    5 files        0 ❌

Results for commit c17195e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 31, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   17m 46s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
328 runs  328 ✔️ 0 💤 0 ❌

Results for commit c17195e.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited

Codecov Report

Patch coverage has no change and project coverage change: +20.40% 🎉

Comparison is base (b6f8fc2) 68.76% compared to head (c17195e) 89.16%.

Additional details and impacted files 
@@              Coverage Diff               @@
##             develop    #7753       +/-   ##
==============================================
+ Coverage      68.76%   89.16%   +20.40%     
+ Complexity     25357    20141     -5216     
==============================================
  Files           2334     1593      -741     
  Lines         148855    60356    -88499     
  Branches        9140     6404     -2736     
==============================================
- Hits          102359    53817    -48542     
+ Misses         44554     5161    -39393     
+ Partials        1942     1378      -564

see 978 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Jul 31, 2023 •
edited

Platform: JUnit Test Report

     553 files           1 errors  552 suites   25m 1s ⏱️
14 057 tests 14 030 ✔️ 27 💤 0 ❌
16 108 runs  16 081 ✔️ 27 💤 0 ❌

Results for commit c17195e.

♻️ This comment has been updated with latest results.

@edward-swirldslabs
07577 - Fixing Platform Core Unit Test Mock Data
c17195e 
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@edward-swirldslabs edward-swirldslabs force-pushed the 07577-Fix-Platform-Core-Unit-Test-Exception branch from a872c91 to c17195e Compare July 31, 2023 21:48
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edward-swirldslabs edward-swirldslabs marked this pull request as ready for review August 1, 2023 14:42
@edward-swirldslabs edward-swirldslabs requested a review from a team as a code owner August 1, 2023 14:42
@edward-swirldslabs edward-swirldslabs merged commit ffa7387 into develop Aug 2, 2023
16 of 17 checks passed
@edward-swirldslabs edward-swirldslabs deleted the 07577-Fix-Platform-Core-Unit-Test-Exception branch August 2, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpetrovic05 lpetrovic05 lpetrovic05 approved these changes

@alittley alittley alittley approved these changes

@poulok poulok Awaiting requested review from poulok poulok is a code owner automatically assigned from hashgraph/platform-hashgraph

@cody-littley cody-littley Awaiting requested review from cody-littley

Assignees

@edward-swirldslabs edward-swirldslabs

Labels
None yet
Projects
None yet
Milestone
v0.42
Development

Successfully merging this pull request may close these issues.

A swirlds-platform-core unit test throws exception that doesn't fail any unit tests
3 participants
@edward-swirldslabs @lpetrovic05 @alittley