Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unwanted genesis migration records #7783

Merged
merged 1 commit into from Aug 2, 2023

Conversation

tinker-michaelj
Copy link
Collaborator

Description:

  • Only export synth creations at true genesis (when lastHandled time is null).

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Node: Unit Test Results

    1 592 files      1 592 suites   15m 0s ⏱️
103 134 tests 103 122 ✔️ 12 💤 0
109 534 runs  109 522 ✔️ 12 💤 0

Results for commit 2b87494.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +20.31% 🎉

Comparison is base (8a7d101) 68.80% compared to head (2b87494) 89.12%.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #7783       +/-   ##
==============================================
+ Coverage      68.80%   89.12%   +20.31%     
+ Complexity     25478    20257     -5221     
==============================================
  Files           2350     1609      -741     
  Lines         149291    60727    -88564     
  Branches        9150     6414     -2736     
==============================================
- Hits          102727    54123    -48604     
+ Misses         44614     5216    -39398     
+ Partials        1950     1388      -562     
Files Changed Coverage Δ
.../mono/state/migration/MigrationRecordsManager.java 98.86% <100.00%> (ø)

... and 979 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Node: E2E Test Results

    1 files      1 suites   17m 51s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit 2b87494.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Node: Integration Test Results

278 tests   278 ✔️  32m 22s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 2b87494.

@tinker-michaelj tinker-michaelj merged commit aaa95c5 into develop Aug 2, 2023
12 checks passed
@tinker-michaelj tinker-michaelj deleted the only-export-synth-records-at-true-genesis branch August 2, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants