New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unwanted genesis migration records #7783
Merged
tinker-michaelj
merged 1 commit into
develop
from
only-export-synth-records-at-true-genesis
Aug 2, 2023
Merged
Avoid unwanted genesis migration records #7783
tinker-michaelj
merged 1 commit into
develop
from
only-export-synth-records-at-true-genesis
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Neeharika-Sompalli
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7783 +/- ##
==============================================
+ Coverage 68.80% 89.12% +20.31%
+ Complexity 25478 20257 -5221
==============================================
Files 2350 1609 -741
Lines 149291 60727 -88564
Branches 9150 6414 -2736
==============================================
- Hits 102727 54123 -48604
+ Misses 44614 5216 -39398
+ Partials 1950 1388 -562
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
lastHandled
time is null).