Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SavepointStack.commit() #7935

Merged
merged 2 commits into from Aug 12, 2023
Merged

Add SavepointStack.commit() #7935

merged 2 commits into from Aug 12, 2023

Conversation

netopyr
Copy link
Contributor

@netopyr netopyr commented Aug 10, 2023

Added SavepointStack.commit()
Removed configuration from stack

To consider: we may want to remove the configuration from HandleContext and have all dependent components use the ConfigProvider instead.

Closes #7934

@netopyr netopyr added this to the v0.42 milestone Aug 10, 2023
@netopyr netopyr requested a review from a team as a code owner August 10, 2023 11:36
@netopyr netopyr self-assigned this Aug 10, 2023
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Node: Unit Test Results

    1 610 files      1 610 suites   13m 17s ⏱️
103 557 tests 103 548 ✔️ 9 💤 0
109 954 runs  109 945 ✔️ 9 💤 0

Results for commit 3fdda96.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Node: E2E Test Results

    1 files      1 suites   17m 59s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit 3fdda96.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Node: Integration Test Results

278 tests   278 ✔️  32m 21s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 3fdda96.

♻️ This comment has been updated with latest results.

@netopyr netopyr requested a review from rbair23 August 10, 2023 12:21
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 90.90% and project coverage change: +19.39% 🎉

Comparison is base (9e694f1) 68.53% compared to head (7d3d85a) 87.92%.
Report is 1 commits behind head on develop.

❗ Current head 7d3d85a differs from pull request most recent head 3fdda96. Consider uploading reports for the commit 3fdda96 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #7935       +/-   ##
==============================================
+ Coverage      68.53%   87.92%   +19.39%     
+ Complexity     25685    20380     -5305     
==============================================
  Files           2370     1622      -748     
  Lines         151251    62210    -89041     
  Branches        9344     6580     -2764     
==============================================
- Hits          103653    54699    -48954     
+ Misses         45572     6049    -39523     
+ Partials        2026     1462      -564     
Files Changed Coverage Δ
...m/hedera/node/app/spi/workflows/HandleContext.java 0.00% <ø> (ø)
...node/app/workflows/handle/FinalizeContextImpl.java 40.00% <60.00%> (+12.72%) ⬆️
...dera/node/app/workflows/handle/HandleWorkflow.java 82.89% <75.00%> (-4.79%) ⬇️
...de/app/workflows/dispatcher/ServiceApiFactory.java 92.85% <100.00%> (ø)
...a/node/app/workflows/handle/HandleContextImpl.java 73.13% <100.00%> (ø)
...app/workflows/handle/stack/SavepointStackImpl.java 100.00% <100.00%> (ø)
...pp/workflows/handle/stack/WritableStatesStack.java 54.54% <100.00%> (ø)

... and 1010 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rbair23
rbair23 previously approved these changes Aug 12, 2023
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
rbair23
rbair23 previously approved these changes Aug 12, 2023
Signed-off-by: Richard Bair <rbair23@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.1% 92.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rbair23 rbair23 merged commit 8cfe4e8 into develop Aug 12, 2023
9 of 10 checks passed
@rbair23 rbair23 deleted the 07934-stack-commit branch August 12, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SavepointStack.commit()
2 participants