Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for legacy sync gossip. #8059

Merged
merged 5 commits into from Aug 21, 2023
Merged

Conversation

cody-littley
Copy link
Contributor

Closes #8058

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley added this to the v0.42 milestone Aug 16, 2023
@cody-littley cody-littley self-assigned this Aug 16, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Node: Unit Test Results

    1 612 files      1 612 suites   11m 48s ⏱️
103 558 tests 103 549 ✔️ 9 💤 0
109 955 runs  109 946 ✔️ 9 💤 0

Results for commit b629523.

♻️ This comment has been updated with latest results.

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Platform: JUnit Test Report

     557 files       557 suites   36m 37s ⏱️
14 056 tests 14 029 ✔️ 27 💤 0
16 153 runs  16 126 ✔️ 27 💤 0

Results for commit b629523.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +19.32% 🎉

Comparison is base (fb87541) 68.51% compared to head (b629523) 87.84%.
Report is 8 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #8059       +/-   ##
==============================================
+ Coverage      68.51%   87.84%   +19.32%     
+ Complexity     25695    20458     -5237     
==============================================
  Files           2370     1629      -741     
  Lines         151459    62583    -88876     
  Branches        9367     6629     -2738     
==============================================
- Hits          103771    54975    -48796     
+ Misses         45652     6141    -39511     
+ Partials        2036     1467      -569     

see 982 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley marked this pull request as ready for review August 16, 2023 20:46
@cody-littley cody-littley requested review from a team as code owners August 16, 2023 20:46
@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Node: E2E Test Results

    1 files      1 suites   17m 56s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit b629523.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Node: Integration Test Results

278 tests   278 ✔️  32m 34s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit b629523.

♻️ This comment has been updated with latest results.

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@cody-littley cody-littley merged commit b860bf5 into develop Aug 21, 2023
17 checks passed
@cody-littley cody-littley deleted the 08058-delete-legacy-sync branch August 21, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Legacy Sync Gosisp
5 participants