New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for legacy sync gossip. #8059
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #8059 +/- ##
==============================================
+ Coverage 68.51% 87.84% +19.32%
+ Complexity 25695 20458 -5237
==============================================
Files 2370 1629 -741
Lines 151459 62583 -88876
Branches 9367 6629 -2738
==============================================
- Hits 103771 54975 -48796
+ Misses 45652 6141 -39511
+ Partials 2036 1467 -569 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Cody Littley <cody@swirldslabs.com>
cody-littley
requested review from
lpetrovic05,
JeffreyDallas,
nathanklick,
timo0,
artemananiev,
OlegMazurov,
kimbor and
alittley
and removed request for
kimbor,
timo0,
OlegMazurov and
artemananiev
August 16, 2023 20:46
edward-swirldslabs
previously approved these changes
Aug 17, 2023
alittley
previously approved these changes
Aug 17, 2023
platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/SyncManagerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Cody Littley <cody@swirldslabs.com>
cody-littley
dismissed stale reviews from alittley and edward-swirldslabs
via
August 17, 2023 19:28
b629523
alittley
approved these changes
Aug 17, 2023
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
edward-swirldslabs
approved these changes
Aug 17, 2023
lpetrovic05
approved these changes
Aug 21, 2023
hendrikebbers
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8058