Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NettyGRPC non linux #8062

Merged
merged 1 commit into from Aug 16, 2023
Merged

fix NettyGRPC non linux #8062

merged 1 commit into from Aug 16, 2023

Conversation

povolev15
Copy link
Contributor

@povolev15 povolev15 commented Aug 16, 2023

fix the issue sonar fix from PR 7839
that causing e2e tests to fail with that error

java.lang.UnsatisfiedLinkError: failed to load the required native library

	at io.netty.channel.epoll.Epoll.ensureAvailability(Epoll.java:81)
	at io.netty.channel.epoll.EpollEventLoop.<clinit>(EpollEventLoop.java:56)
	at io.netty.channel.epoll.EpollEventLoopGroup.newChild(EpollEventLoopGroup.java:186)
	at io.netty.channel.epoll.EpollEventLoopGroup.newChild(EpollEventLoopGroup.java:37)
	at io.netty.util.concurrent.MultithreadEventExecutorGroup.<init>(MultithreadEventExecutorGroup.java:84)
	at io.netty.util.concurrent.MultithreadEventExecutorGroup.<init>(MultithreadEventExecutorGroup.java:60)
	at io.netty.util.concurrent.MultithreadEventExecutorGroup.<init>(MultithreadEventExecutorGroup.java:49)
	at io.netty.channel.MultithreadEventLoopGroup.<init>(MultithreadEventLoopGroup.java:59)
	at io.netty.channel.epoll.EpollEventLoopGroup.<init>(EpollEventLoopGroup.java:114)
	at io.netty.channel.epoll.EpollEventLoopGroup.<init>(EpollEventLoopGroup.java:101)
	at io.netty.channel.epoll.EpollEventLoopGroup.<init>(EpollEventLoopGroup.java:78)
	at io.netty.channel.epoll.EpollEventLoopGroup.<init>(EpollEventLoopGroup.java:54)
	at io.netty.channel.epoll.EpollEventLoopGroup.<init>(EpollEventLoopGroup.java:47)
	at com.hedera.node.app.grpc.impl.netty.NettyGrpcServerManager.builderFor(NettyGrpcServerManager.java:268)
	at com.hedera.node.app.grpc.impl.netty.NettyGrpcServerManager.start(NettyGrpcServerManager.java:149)
	at com.hedera.node.app.Hedera.startGrpcServer(Hedera.java:567)
	at com.hedera.node.app.Hedera.run(Hedera.java:515)

Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@povolev15 povolev15 self-assigned this Aug 16, 2023
@povolev15 povolev15 requested a review from a team as a code owner August 16, 2023 20:42
@github-actions
Copy link

Node: Unit Test Results

    1 612 files      1 612 suites   11m 45s ⏱️
103 558 tests 103 549 ✔️ 9 💤 0
109 955 runs  109 946 ✔️ 9 💤 0

Results for commit 261149a.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 80.95% and project coverage change: +19.32% 🎉

Comparison is base (fb87541) 68.51% compared to head (261149a) 87.84%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #8062       +/-   ##
==============================================
+ Coverage      68.51%   87.84%   +19.32%     
+ Complexity     25695    20457     -5238     
==============================================
  Files           2370     1629      -741     
  Lines         151459    62583    -88876     
  Branches        9367     6629     -2738     
==============================================
- Hits          103771    54974    -48797     
+ Misses         45652     6141    -39511     
+ Partials        2036     1468      -568     
Files Changed Coverage Δ
...de/app/grpc/impl/netty/NettyGrpcServerManager.java 9.55% <0.00%> (-55.86%) ⬇️
...node/app/service/file/impl/base/FileQueryBase.java 100.00% <ø> (ø)
.../service/file/impl/handlers/FileDeleteHandler.java 88.88% <100.00%> (ø)
...ice/file/impl/handlers/FileGetContentsHandler.java 97.05% <100.00%> (+10.39%) ⬆️
...service/file/impl/handlers/FileGetInfoHandler.java 91.66% <100.00%> (+5.95%) ⬆️

... and 978 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions
Copy link

Node: E2E Test Results

    1 files      1 suites   18m 12s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit 261149a.

@jsync-swirlds jsync-swirlds changed the title fix NettyGRPC no linux fix NettyGRPC non linux Aug 16, 2023
@github-actions
Copy link

Node: Integration Test Results

278 tests   278 ✔️  32m 6s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 261149a.

Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@povolev15 povolev15 merged commit 16ee5e8 into develop Aug 16, 2023
11 of 12 checks passed
@povolev15 povolev15 deleted the fix-NettyGrpc-Non-linux branch August 16, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants