New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix return File instead of optional when call getFileLeaf #8204
Conversation
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
...-service-impl/src/main/java/com/hedera/node/app/service/file/impl/ReadableFileStoreImpl.java
Outdated
Show resolved
Hide resolved
...pl/src/main/java/com/hedera/node/app/service/contract/impl/infra/HevmTransactionFactory.java
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #8204 +/- ##
==============================================
+ Coverage 0 87.32% +87.32%
- Complexity 0 20517 +20517
==============================================
Files 0 1638 +1638
Lines 0 63180 +63180
Branches 0 6709 +6709
==============================================
+ Hits 0 55169 +55169
- Misses 0 6514 +6514
- Partials 0 1497 +1497
☔ View full report in Codecov by Sentry. |
...pl/src/main/java/com/hedera/node/app/service/contract/impl/infra/HevmTransactionFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
SonarCloud Quality Gate failed. 1 Bug 64.1% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
...pl/src/main/java/com/hedera/node/app/service/contract/impl/infra/HevmTransactionFactory.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...-service-impl/src/main/java/com/hedera/node/app/service/file/impl/ReadableFileStoreImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix return null instead of optional when call getFileLeaf
Related issue(s):
Fixes #8198