Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix return File instead of optional when call getFileLeaf #8204

Merged
merged 2 commits into from Aug 24, 2023

Conversation

povolev15
Copy link
Contributor

fix return null instead of optional when call getFileLeaf

Related issue(s):

Fixes #8198

Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Node: Unit Test Results

    1 617 files      1 617 suites   17m 13s ⏱️
103 583 tests 103 574 ✔️ 9 💤 0
109 980 runs  109 971 ✔️ 9 💤 0

Results for commit 139651b.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 65.21% and project coverage change: +87.32% 🎉

Comparison is base (d918f8d) 0.00% compared to head (139651b) 87.32%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #8204       +/-   ##
==============================================
+ Coverage           0   87.32%   +87.32%     
- Complexity         0    20517    +20517     
==============================================
  Files              0     1638     +1638     
  Lines              0    63180    +63180     
  Branches           0     6709     +6709     
==============================================
+ Hits               0    55169    +55169     
- Misses             0     6514     +6514     
- Partials           0     1497     +1497     
Files Changed Coverage Δ
...-app/src/main/java/com/hedera/node/app/Hedera.java 0.00% <0.00%> (ø)
...ce/file/impl/codec/FileServiceStateTranslator.java 91.42% <33.33%> (ø)
...e/app/service/file/impl/ReadableFileStoreImpl.java 100.00% <100.00%> (ø)
.../service/file/impl/handlers/FileAppendHandler.java 87.14% <100.00%> (ø)
.../service/file/impl/handlers/FileDeleteHandler.java 88.88% <100.00%> (ø)
...ce/file/impl/handlers/FileSystemDeleteHandler.java 93.54% <100.00%> (ø)
.../file/impl/handlers/FileSystemUndeleteHandler.java 93.10% <100.00%> (ø)
.../service/file/impl/handlers/FileUpdateHandler.java 96.47% <100.00%> (ø)
...contract/impl/infra/EthereumCallDataHydration.java 100.00% <100.00%> (ø)
...ce/contract/impl/infra/HevmTransactionFactory.java 98.13% <100.00%> (ø)

... and 1628 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Node: E2E Test Results

    1 files      1 suites   19m 5s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit 139651b.

♻️ This comment has been updated with latest results.

@jsync-swirlds jsync-swirlds changed the title fix return null instead of optional when call getFileLeaf fix return File instead of optional when call getFileLeaf Aug 24, 2023
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

64.1% 64.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Node: Integration Test Results

278 tests   278 ✔️  32m 21s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 139651b.

Copy link

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@povolev15 povolev15 merged commit d7745b6 into develop Aug 24, 2023
11 of 12 checks passed
@povolev15 povolev15 deleted the 8198-remove-optional-return-null-instead branch August 24, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadableFileStore.getFileLeaf() need to not return Optional
7 participants