Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align staking property names with HIPs #8247

Merged
merged 6 commits into from Aug 31, 2023

Conversation

tinker-michaelj
Copy link
Collaborator

@tinker-michaelj tinker-michaelj commented Aug 28, 2023

Description:

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented Aug 28, 2023

Node: E2E Test Results

    1 files      1 suites   19m 36s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit 65bedb0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 28, 2023

Node: Unit Test Results

    1 601 files      1 601 suites   12m 33s ⏱️
103 535 tests 103 525 ✔️ 10 💤 0
109 917 runs  109 907 ✔️ 10 💤 0

Results for commit 65bedb0.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@6024f56). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #8247   +/-   ##
==========================================
  Coverage           ?   87.26%           
  Complexity         ?    20395           
==========================================
  Files              ?     1626           
  Lines              ?    62984           
  Branches           ?     6694           
==========================================
  Hits               ?    54963           
  Misses             ?     6525           
  Partials           ?     1496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 28, 2023

Node: Integration Test Results

278 tests   278 ✔️  32m 27s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 65bedb0.

♻️ This comment has been updated with latest results.

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in regards to hedera-app

@tinker-michaelj tinker-michaelj merged commit a1acd57 into develop Aug 31, 2023
12 checks passed
@tinker-michaelj tinker-michaelj deleted the 08233-align-staking-props branch August 31, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename staking properties for clearer HIP-406 and HIP-782 alignment
4 participants