old logging API moved to legacy package #8459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
hendrikebbers
requested review from
poulok,
JeffreyDallas,
leninmehedy,
artemananiev,
OlegMazurov,
timo0,
rbair23,
povolev15,
cody-littley and
netopyr
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8459 +/- ##
==============================================
+ Coverage 0 65.23% +65.23%
- Complexity 0 29595 +29595
==============================================
Files 0 3258 +3258
Lines 0 124187 +124187
Branches 0 12867 +12867
==============================================
+ Hits 0 81011 +81011
- Misses 0 40118 +40118
- Partials 0 3058 +3058
☔ View full report in Codecov by Sentry. |
cody-littley
previously approved these changes
Sep 8, 2023
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
netopyr
previously approved these changes
Sep 11, 2023
OlegMazurov
previously approved these changes
Oct 6, 2023
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
hendrikebbers
dismissed stale reviews from OlegMazurov, JeffreyDallas, cody-littley, netopyr, and timo0
via
58d1dd4
|
Kudos, SonarCloud Quality Gate passed!
|
nathanklick
previously approved these changes
Oct 23, 2023
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com> # Conflicts: # platform-sdk/platform-apps/tests/AddressBookTestingTool/src/main/java/com/swirlds/demo/addressbook/AddressBookTestingToolMain.java # platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/PlatformTestingToolState.java # platform-sdk/platform-apps/tests/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/SttTransactionPool.java # platform-sdk/swirlds-common/src/main/java/com/swirlds/common/crypto/engine/EcdsaSecp256k1Verifier.java # platform-sdk/swirlds-common/src/main/java/com/swirlds/common/scratchpad/Scratchpad.java # platform-sdk/swirlds-jasperdb/src/main/java/com/swirlds/merkledb/MerkleDbDataSource.java # platform-sdk/swirlds-jasperdb/src/main/java/com/swirlds/merkledb/files/DataFileCommon.java # platform-sdk/swirlds-jasperdb/src/main/java/com/swirlds/merkledb/files/MemoryIndexDiskKeyValueStore.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/Browser.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/ConsensusImpl.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/ConsensusRounds.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/Crypto.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/SwirldsPlatform.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/SwirldsPlatformBuilder.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/components/EventIntake.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/creation/tipset/TipsetTracker.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/creation/tipset/TipsetWeightCalculator.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/linking/OrphanBufferingLinker.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/validation/SignatureValidator.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/gossip/sync/SyncManagerImpl.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/network/SocketConnection.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/network/connectivity/InboundConnectionHandler.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/recovery/EventRecoveryWorkflow.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/SwirldStateManagerImpl.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/address/AbstractAddressBookStore.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/address/AddressBookManagerImpl.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/iss/ConsensusHashManager.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/signed/SignedStateFileUtils.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/signed/StartupStateUtils.java
# Conflicts: # platform-sdk/swirlds-common/src/main/java/com/swirlds/common/merkle/synchronization/internal/TeacherSendingThread.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/linking/InOrderLinker.java
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
timo0
requested review from
timo0,
netopyr,
OlegMazurov,
cody-littley,
JeffreyDallas and
nathanklick
timo0
approved these changes
Oct 30, 2023
cody-littley
approved these changes
Oct 31, 2023
imalygin
approved these changes
Oct 31, 2023
netopyr
approved these changes
Nov 1, 2023
petreze
pushed a commit
that referenced
this pull request
Nov 2, 2023
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de> Signed-off-by: Timo Brandstätter <timo@swirldslabs.com> Co-authored-by: Timo Brandstätter <timo@swirldslabs.com> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
imalygin
pushed a commit
that referenced
this pull request
Nov 13, 2023
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de> Signed-off-by: Timo Brandstätter <timo@swirldslabs.com> Co-authored-by: Timo Brandstätter <timo@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as preparation for #5424