Cleanup Module patching #8561
Merged
Cleanup Module patching #8561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjohannes
force-pushed
the
cleanup-patching
branch
from
4a028f1
to
72773e7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8561 +/- ##
==========================================
Coverage ? 65.25%
Complexity ? 29680
==========================================
Files ? 3262
Lines ? 124594
Branches ? 12922
==========================================
Hits ? 81310
Misses ? 40208
Partials ? 3076 ☔ View full report in Codecov by Sentry. |
jjohannes
force-pushed
the
cleanup-patching
branch
2 times, most recently
from
55ac913
to
d695cfa
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jjohannes
requested review from
JeffreyDallas,
nathanklick,
edward-swirldslabs,
timo0,
rbair23 and
mhess-swl
edward-swirldslabs
previously approved these changes
Sep 13, 2023
nathanklick
force-pushed
the
cleanup-patching
branch
from
d695cfa
to
5071fbb
Compare
|
SonarCloud Quality Gate failed.
|
nathanklick
force-pushed
the
cleanup-patching
branch
from
15bb5ae
to
7f9c5e5
Compare
edward-swirldslabs
previously approved these changes
Oct 23, 2023
|
Once #8455 is merged, I will rebase this again and address the conflicts and problem. |
jjohannes
force-pushed
the
cleanup-patching
branch
from
779358b
to
b6c52b5
Compare
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes
force-pushed
the
cleanup-patching
branch
from
b6c52b5
to
d7cc35f
Compare
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
nathanklick
approved these changes
Nov 1, 2023
edward-swirldslabs
approved these changes
Nov 1, 2023
timo0
approved these changes
Nov 1, 2023
petreze
pushed a commit
that referenced
this pull request
Nov 2, 2023
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
imalygin
pushed a commit
that referenced
this pull request
Nov 13, 2023
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
com.hedera.hashgraph.jpms-modules.gradle.ktsdata/libsto be real Modulesdata/libdata/libhas amodule-info.class. This can be extended later to check more precisely what we expect/allow indata/lib.The patched modules might not yet be ready to really run on the module path. That is, they might miss certain "requires" at runtime and there could be issue with Jars containing native code. Hence this PR does not change how we start/package the application. However, in a follow up this can be addressed and then also
jlinkandjpackagecould be used.Related issue(s):
Notes for reviewer:
Checklist