Cherry pick for release 0.42 account balance test #8866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffreyDallas
requested review from
a team,
rbair23,
dalvizu,
poulok,
netopyr,
Nana-EC,
SimiHunjan,
steven-sheehy,
nickpoorman and
nathanklick
as code owners
JeffreyDallas
requested review from
qnswirlds and
jeromy-cannon
and removed request for
a team
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.42 #8866 +/- ##
===================================================
+ Coverage 68.46% 87.02% +18.56%
+ Complexity 25876 20502 -5374
===================================================
Files 2380 1636 -744
Lines 152985 63828 -89157
Branches 9565 6806 -2759
===================================================
- Hits 104747 55549 -49198
+ Misses 46138 6761 -39377
+ Partials 2100 1518 -582 ☔ View full report in Codecov by Sentry. |
jeromy-cannon
approved these changes
Sep 27, 2023
mhess-swl
approved these changes
Sep 28, 2023
|
LGTM. Looks like DCO is failing though 😞 |
JeffreyDallas
force-pushed
the
release0.42-cherry-pick
branch
from
5e52051
to
002896b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Test result
https://swirldslabs.slack.com/archives/C03G7CBJJ06/p1695655070460749
https://swirldslabs.slack.com/archives/C03G7CBJJ06/p1695673611149779