Differential testing analytic engine: State file file dumper now dumps special files #8991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And for system files it tells you what file it is. And you can ask for the report _without_ the file contents (much smaller file, suitable for putting into a spreadsheet. Signed-off-by: David Bakin <117694041+david-bakin-sl@users.noreply.github.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8991 +/- ##
==========================================
Coverage ? 65.02%
Complexity ? 29243
==========================================
Files ? 3225
Lines ? 123021
Branches ? 12634
==========================================
Hits ? 79999
Misses ? 40032
Partials ? 2990 ☔ View full report in Codecov by Sentry. |
Signed-off-by: David Bakin <117694041+david-bakin-sl@users.noreply.github.com>
...-node/cli-clients/src/main/java/com/hedera/services/cli/signedstate/DumpFilesSubcommand.java
Show resolved
Hide resolved
mhess-swl
previously approved these changes
Oct 3, 2023
...-node/cli-clients/src/main/java/com/hedera/services/cli/signedstate/DumpFilesSubcommand.java
Show resolved
Hide resolved
...-node/cli-clients/src/main/java/com/hedera/services/cli/signedstate/DumpFilesSubcommand.java
Outdated
Show resolved
Hide resolved
(and politely - I hope - decline a few as well) Signed-off-by: David Bakin <117694041+david-bakin-sl@users.noreply.github.com>
mhess-swl
approved these changes
Oct 3, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
...-node/cli-clients/src/main/java/com/hedera/services/cli/signedstate/DumpFilesSubcommand.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
State file file dumper now dumps special files
Related issue(s):
Fixes #8990
Checklist