Validations for dispatchSyntheticTxn #9308

mustafauzunn · 2023-10-17T11:11:30Z

Description:

Add checks to HandleContextImpl.dispatchSyntheticTxn() right before we call dispatchHandle()

Related issue(s):

Fixes #9213

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

github-actions · 2023-10-17T11:40:01Z

Node: E2E Test Results

    1 files ±    0     1 suites ±0 21m 24s ⏱️ + 21m 24s
310 tests +309 310 ✔️ +310 0 💤 ±0 0 ❌ - 1
332 runs +331 332 ✔️ +332 0 💤 ±0 0 ❌ - 1

Results for commit d7f7847. ± Comparison against base commit abb9bb4.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.

EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

github-actions · 2023-10-17T11:41:07Z

Node: Unit Test Results

    2 276 files ±0     2 276 suites ±0 1h 36m 19s ⏱️ + 2m 39s
118 367 tests +4 118 333 ✔️ +4 34 💤 ±0 0 ❌ ±0
126 628 runs +4 126 594 ✔️ +4 34 💤 ±0 0 ❌ ±0

Results for commit d7f7847. ± Comparison against base commit abb9bb4.

♻️ This comment has been updated with latest results.

codecov · 2023-10-17T11:42:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@abb9bb4). Click here to learn what that means.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #9308   +/-   ##
==========================================
  Coverage           ?   65.42%           
  Complexity         ?    29987           
==========================================
  Files              ?     3296           
  Lines              ?   125603           
  Branches           ?    13037           
==========================================
  Hits               ?    82176           
  Misses             ?    40285           
  Partials           ?     3142

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-10-17T11:47:33Z

Node: Integration Test Results

280 tests ±0 280 ✔️ ±0 28m 28s ⏱️ - 4m 40s
    5 suites ±0     0 💤 ±0
    5 files ±0     0 ❌ ±0

Results for commit d7f7847. ± Comparison against base commit abb9bb4.

♻️ This comment has been updated with latest results.

github-actions · 2023-10-17T12:54:40Z

Node: HAPI Test Results

1 245 tests +3 851 ✔️ +26 1h 25m 31s ⏱️ + 7m 34s
  166 suites +1 394 💤 - 23
  166 files +1     0 ❌ ±  0

Results for commit d7f7847. ± Comparison against base commit abb9bb4.

♻️ This comment has been updated with latest results.

Neeharika-Sompalli

Some unit tests and HAPI tests are failing on this PR 🤔

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

...ra-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleContextImpl.java

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

…9213-validations-dispatchSyntheticTxn

sonarcloud · 2023-10-19T18:29:53Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

…9213-validations-dispatchSyntheticTxn

...ra-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleContextImpl.java

# Conflicts: # hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/handle/HandleContextImplTest.java

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/SolvencyPreCheck.java

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

tinker-michaelj

Since the handle workflow will ultimately assign a guaranteed-unique TransactionID to a child transaction, I think the duplicate check is superfluous. But overall this makes sense to me, ty @mustafauzunn !

...ra-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleContextImpl.java

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleContextImpl.java

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

Neeharika-Sompalli

LGTM !

tinker-michaelj

I think we should merge and then urgently fix XTest's; c.f. #9776

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech> Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech> Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Co-authored-by: Valentin Valkanov <valentin.valkanov@limechain.tech> Co-authored-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech> Co-authored-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech> Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech> Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Co-authored-by: Valentin Valkanov <valentin.valkanov@limechain.tech> Co-authored-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech> Co-authored-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Signed-off-by: Nick Poorman <nick@swirldslabs.com>

mustafauzunn added 5 commits October 16, 2023 14:04

feature: add validations to HandleContextImpl.dispatchSyntheticTxn

8482c26

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

style: formatting

437e7ba

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

feature: change validations

a22468b

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

feature: remove unused parameter

abc59ac

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

style: formatting

9891413

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

mustafauzunn requested a review from a team as a code owner October 17, 2023 11:11

mustafauzunn requested a review from Neeharika-Sompalli October 17, 2023 11:11

mustafauzunn self-assigned this Oct 17, 2023

mustafauzunn added the Limechain Work planned for the LimeChain team label Oct 17, 2023

stoyanov-st mentioned this pull request Oct 18, 2023

Add X tests Key verifications for Freeze/Unfreeze calls #9330

Closed

2 tasks

Neeharika-Sompalli reviewed Oct 18, 2023

View reviewed changes

mustafauzunn marked this pull request as draft October 19, 2023 06:28

feature: improve response from catch

3565d1e

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

MrValioBg reviewed Oct 19, 2023

View reviewed changes

...ra-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleContextImpl.java Outdated Show resolved Hide resolved

mustafauzunn and others added 4 commits October 19, 2023 15:58

style: formatting

f262b98

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

refactor: apply PR comments

11f96e6

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

style: formatting

581ee2c

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

tests: fix failing unit tests

5f2a447

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

mustafauzunn marked this pull request as ready for review October 19, 2023 14:51

Merge branch 'develop' of github.com:hashgraph/hedera-services into 0…

f7d3076

…9213-validations-dispatchSyntheticTxn

Merge branch 'develop' of github.com:hashgraph/hedera-services into 0…

795583c

…9213-validations-dispatchSyntheticTxn

mustafauzunn marked this pull request as draft October 20, 2023 12:45

tinker-michaelj reviewed Oct 20, 2023

View reviewed changes

...ra-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleContextImpl.java Outdated Show resolved Hide resolved

Merge branch 'develop' into 09213-validations-dispatchSyntheticTxn

802b22c

# Conflicts: # hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/handle/HandleContextImplTest.java

stoyanov-st added 4 commits October 24, 2023 11:32

refactor: keep this keyword

145eb26

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

Merge branch 'develop' into 09213-validations-dispatchSyntheticTxn

97d9f9a

Merge branch 'develop' into 09213-validations-dispatchSyntheticTxn

1400292

feat: include duplication, solvency and timebox checks

e87b568

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

stoyanov-st requested review from netopyr and tinker-michaelj October 26, 2023 10:08

Merge branch 'develop' into 09213-validations-dispatchSyntheticTxn

f74d6e0

stoyanov-st marked this pull request as ready for review October 30, 2023 08:44

stoyanov-st added 2 commits November 1, 2023 09:28

Merge branch 'develop' into 09213-validations-dispatchSyntheticTxn

cb66a35

# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/SolvencyPreCheck.java

fix: post merge side effects

46cd0e3

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

tinker-michaelj previously approved these changes Nov 1, 2023

View reviewed changes

netopyr reviewed Nov 2, 2023

View reviewed changes

netopyr linked an issue Nov 2, 2023 that may be closed by this pull request

Add additional checks for child transactions #8495

Closed

stoyanov-st added 2 commits November 3, 2023 14:08

Merge branch 'develop' into 09213-validations-dispatchSyntheticTxn

25a3da7

refactor: address PR comments

0f8b13c

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

stoyanov-st dismissed tinker-michaelj’s stale review via 0f8b13c November 3, 2023 15:18

test: fix test

5e5c6f5

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

stoyanov-st requested review from tinker-michaelj and netopyr November 7, 2023 08:04

stoyanov-st and others added 5 commits November 7, 2023 10:13

Merge branch 'develop' into 09213-validations-dispatchSyntheticTxn

f99dc5e

# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleContextImpl.java

test: fix another test

0c92f47

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

Merge branch 'develop' into 09213-validations-dispatchSyntheticTxn

78cd13e

fix: pass correct function to validator

6021c54

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

fix failing HAPI tests

d7f7847

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

Neeharika-Sompalli approved these changes Nov 8, 2023

View reviewed changes

tinker-michaelj approved these changes Nov 8, 2023

View reviewed changes

Neeharika-Sompalli merged commit f593934 into develop Nov 8, 2023
16 of 17 checks passed

Neeharika-Sompalli deleted the 09213-validations-dispatchSyntheticTxn branch November 8, 2023 20:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validations for dispatchSyntheticTxn #9308

Validations for dispatchSyntheticTxn #9308

mustafauzunn commented Oct 17, 2023

github-actions bot commented Oct 17, 2023 •

edited

github-actions bot commented Oct 17, 2023 •

edited

codecov bot commented Oct 17, 2023 •

edited

github-actions bot commented Oct 17, 2023 •

edited

github-actions bot commented Oct 17, 2023 •

edited

Neeharika-Sompalli left a comment

sonarcloud bot commented Oct 19, 2023

tinker-michaelj left a comment

Neeharika-Sompalli left a comment

tinker-michaelj left a comment

Validations for dispatchSyntheticTxn #9308

Validations for dispatchSyntheticTxn #9308

Conversation

mustafauzunn commented Oct 17, 2023

github-actions bot commented Oct 17, 2023 • edited

Node: E2E Test Results

github-actions bot commented Oct 17, 2023 • edited

Node: Unit Test Results

codecov bot commented Oct 17, 2023 • edited

Codecov Report

github-actions bot commented Oct 17, 2023 • edited

Node: Integration Test Results

github-actions bot commented Oct 17, 2023 • edited

Node: HAPI Test Results

Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 19, 2023

tinker-michaelj left a comment

Choose a reason for hiding this comment

Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

tinker-michaelj left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 17, 2023 •

edited

github-actions bot commented Oct 17, 2023 •

edited

codecov bot commented Oct 17, 2023 •

edited

github-actions bot commented Oct 17, 2023 •

edited

github-actions bot commented Oct 17, 2023 •

edited