Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable remaining tests from TokenTransactSpecs #9313

Merged
merged 13 commits into from Nov 7, 2023

Conversation

Ivo-Yankov
Copy link
Contributor

@Ivo-Yankov Ivo-Yankov commented Oct 17, 2023

Description:

Enables the remaining tests from the suite:

  • canTransactInTokenWithSelfDenominatedFixedFee
  • collectorIsChargedFractionalFeeUnlessExempt

Related issue(s):

Fixes #8913

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Node: E2E Test Results

    1 files      1 suites   21m 23s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit c45ac29.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Node: Unit Test Results

    2 271 files      2 271 suites   1h 24m 49s ⏱️
118 338 tests 118 304 ✔️ 34 💤 0
126 599 runs  126 565 ✔️ 34 💤 0

Results for commit c45ac29.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Node: Integration Test Results

280 tests   280 ✔️  32m 51s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit c45ac29.

♻️ This comment has been updated with latest results.

@Ivo-Yankov Ivo-Yankov self-assigned this Oct 19, 2023
@Ivo-Yankov Ivo-Yankov added the Limechain Work planned for the LimeChain team label Oct 19, 2023
@Ivo-Yankov Ivo-Yankov marked this pull request as ready for review October 19, 2023 09:46
@Ivo-Yankov Ivo-Yankov requested review from a team as code owners October 19, 2023 09:46
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Node: HAPI Test Results

1 242 tests   804 ✔️  1h 15m 32s ⏱️
   165 suites  438 💤
   165 files        0

Results for commit c45ac29.

♻️ This comment has been updated with latest results.

@Ivo-Yankov Ivo-Yankov marked this pull request as draft October 19, 2023 11:33
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
…sactspec-errors' into 8913-resolve-remaining-tokentransactspec-errors
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (824d007) 0.00% compared to head (335e7e9) 65.23%.

❗ Current head 335e7e9 differs from pull request most recent head c45ac29. Consider uploading reports for the commit c45ac29 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #9313       +/-   ##
==============================================
+ Coverage           0   65.23%   +65.23%     
- Complexity         0    29603    +29603     
==============================================
  Files              0     3258     +3258     
  Lines              0   124207   +124207     
  Branches           0    12874    +12874     
==============================================
+ Hits               0    81031    +81031     
- Misses             0    40108    +40108     
- Partials           0     3068     +3068     
Files Coverage Δ
...andlers/transfer/customfees/CustomFeeAssessor.java 82.50% <93.33%> (ø)
...ansfer/customfees/CustomFractionalFeeAssessor.java 75.49% <60.00%> (ø)

... and 3256 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ivo-Yankov Ivo-Yankov marked this pull request as ready for review October 23, 2023 12:26
…errors

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
…errors

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@Ivo-Yankov Ivo-Yankov merged commit 0eefed7 into develop Nov 7, 2023
10 of 11 checks passed
@Ivo-Yankov Ivo-Yankov deleted the 8913-resolve-remaining-tokentransactspec-errors branch November 7, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve remaining TokenTransactSpec errors
2 participants