New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remaining system file updates #9354
Conversation
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Node: E2E Test Results 1 files ± 0 1 suites ±0 21m 28s ⏱️ + 21m 28s Results for commit b105146. ± Comparison against base commit 0806629. This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #9354 +/- ##
=============================================
- Coverage 65.44% 65.44% -0.01%
- Complexity 29983 29994 +11
=============================================
Files 3296 3296
Lines 125494 125627 +133
Branches 13017 13035 +18
=============================================
+ Hits 82130 82217 +87
- Misses 40238 40275 +37
- Partials 3126 3135 +9
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Return default fees if not found in FeeManager Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
# Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/junit/HapiTestEnv.java
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well designed, as usual.
I do have some questions to help me in understanding what's being done here, and a few comment/nitpick items.
hedera-node/hedera-app/src/main/java/com/hedera/node/app/fees/FeeManager.java
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/fees/FeeManager.java
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/fees/FeeManager.java
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/fees/FeeManager.java
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/throttle/ThrottleManager.java
Show resolved
Hide resolved
.../hedera-app/src/main/java/com/hedera/node/app/workflows/handle/SystemFileUpdateFacility.java
Show resolved
Hide resolved
.../hedera-app/src/main/java/com/hedera/node/app/workflows/handle/SystemFileUpdateFacility.java
Show resolved
Hide resolved
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
This PR adds logic to update the fee schedule and permissions after an override.