Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining system file updates #9354

Merged
merged 26 commits into from Nov 9, 2023
Merged

Conversation

netopyr
Copy link
Contributor

@netopyr netopyr commented Oct 19, 2023

This PR adds logic to update the fee schedule and permissions after an override.

Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@netopyr netopyr added this to the v0.44 milestone Oct 19, 2023
@netopyr netopyr self-assigned this Oct 19, 2023
@netopyr netopyr requested a review from a team as a code owner October 19, 2023 11:20
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 28s ⏱️ + 21m 28s
310 tests +309  310 ✔️ +310  0 💤 ±0  0  - 1 
332 runs  +331  332 ✔️ +332  0 💤 ±0  0  - 1 

Results for commit b105146. ± Comparison against base commit 0806629.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Node: Unit Test Results

    2 276 files  ±0      2 276 suites  ±0   1h 35m 17s ⏱️ + 4m 12s
118 371 tests +8  118 337 ✔️ +8  34 💤 ±0  0 ±0 
126 632 runs  +8  126 598 ✔️ +8  34 💤 ±0  0 ±0 

Results for commit b105146. ± Comparison against base commit 0806629.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 27s ⏱️ -12s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit b105146. ± Comparison against base commit 0806629.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Node: HAPI Test Results

1 246 tests  +4   853 ✔️ +28   1h 22m 20s ⏱️ + 2m 43s
   166 suites +1   393 💤  - 24 
   166 files   +1       0 ±  0 

Results for commit b105146. ± Comparison against base commit 0806629.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (0806629) 65.44% compared to head (b105146) 65.44%.
Report is 12 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9354      +/-   ##
=============================================
- Coverage      65.44%   65.44%   -0.01%     
- Complexity     29983    29994      +11     
=============================================
  Files           3296     3296              
  Lines         125494   125627     +133     
  Branches       13017    13035      +18     
=============================================
+ Hits           82130    82217      +87     
- Misses         40238    40275      +37     
- Partials        3126     3135       +9     
Files Coverage Δ
...com/hedera/node/app/config/ConfigProviderImpl.java 93.93% <100.00%> (+0.06%) ⬆️
.../com/hedera/node/app/throttle/ThrottleManager.java 96.15% <100.00%> (+5.52%) ⬆️
...dera/node/app/workflows/handle/HandleWorkflow.java 75.00% <100.00%> (+0.07%) ⬆️
.../hedera/node/app/service/mono/utils/MiscUtils.java 98.74% <100.00%> (ø)
...p/throttle/impl/NetworkUtilizationManagerImpl.java 6.49% <0.00%> (ø)
...app/workflows/handle/SystemFileUpdateFacility.java 94.44% <93.93%> (+27.77%) ⬆️
...-app/src/main/java/com/hedera/node/app/Hedera.java 0.00% <0.00%> (ø)
...main/java/com/hedera/node/app/fees/FeeManager.java 18.46% <16.21%> (+7.55%) ⬆️

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Return default fees if not found in FeeManager

Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@netopyr netopyr linked an issue Nov 2, 2023 that may be closed by this pull request
@netopyr netopyr linked an issue Nov 2, 2023 that may be closed by this pull request
@netopyr netopyr requested a review from a team as a code owner November 7, 2023 18:51
@netopyr netopyr requested a review from iwsimon November 7, 2023 18:51
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/junit/HapiTestEnv.java
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
iwsimon
iwsimon previously approved these changes Nov 8, 2023
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well designed, as usual.
I do have some questions to help me in understanding what's being done here, and a few comment/nitpick items.

@netopyr netopyr merged commit c615bda into develop Nov 9, 2023
15 of 17 checks passed
@netopyr netopyr deleted the 08912-remaining-system-file-updates branch November 9, 2023 09:00
ilko-iliev-lime pushed a commit that referenced this pull request Nov 10, 2023
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve TargetNetworkPrep errors Update HAPI-permission file
5 participants