Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests from CannotDeleteSystemEntitiesSuite #9440

Merged

Conversation

Ivo-Yankov
Copy link
Contributor

@Ivo-Yankov Ivo-Yankov commented Oct 24, 2023

Description:
Enables all tests from the suite

Related issue(s):

Fixes #9439

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@Ivo-Yankov Ivo-Yankov linked an issue Oct 24, 2023 that may be closed by this pull request
@Ivo-Yankov Ivo-Yankov self-assigned this Oct 24, 2023
@Ivo-Yankov Ivo-Yankov added the Limechain Work planned for the LimeChain team label Oct 24, 2023
@Ivo-Yankov Ivo-Yankov marked this pull request as ready for review October 24, 2023 10:15
@Ivo-Yankov Ivo-Yankov requested review from a team as code owners October 24, 2023 10:15
@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Node: E2E Test Results

    1 files      1 suites   20m 38s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit 2027cbd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Node: Unit Test Results

    2 259 files      2 259 suites   1h 32m 1s ⏱️
118 227 tests 118 193 ✔️ 34 💤 0
126 486 runs  126 452 ✔️ 34 💤 0

Results for commit 2027cbd.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Node: Integration Test Results

280 tests   280 ✔️  32m 49s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 2027cbd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Node: HAPI Test Results

1 242 tests   738 ✔️  1h 9m 59s ⏱️
   165 suites  504 💤
   165 files        0

Results for commit 2027cbd.

♻️ This comment has been updated with latest results.

…entitiessuite

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Copy link
Contributor

@povolev15 povolev15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, UNIT test , integration and E2E are failing

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems CI checks are deeply unhappy. 😞

@codecov
Copy link

codecov bot commented Oct 27, 2023

We're currently processing your upload. This comment will be updated when the results are available.

@povolev15
Copy link
Contributor

E2E still failing

@Ivo-Yankov Ivo-Yankov merged commit c1c25b0 into develop Oct 31, 2023
12 of 13 checks passed
@Ivo-Yankov Ivo-Yankov deleted the 9439-enable-tests-from-cannotdeletesystementitiessuite branch October 31, 2023 09:30
imalygin pushed a commit that referenced this pull request Nov 13, 2023
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enable tests from CannotDeleteSystemEntitiesSuite
4 participants