Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9479: Add more logs to debug virtual map reconnect issues #9481

Merged
merged 5 commits into from Nov 1, 2023

Conversation

artemananiev
Copy link
Member

More logs and more try-catch blocks.

Fixes: #9479
Signed-off-by: Artem Ananev artem.ananev@swirldslabs.com

Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Node: HAPI Test Results

1 242 tests   772 ✔️  1h 11m 11s ⏱️
   165 suites  470 💤
   165 files        0

Results for commit bf7f8e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Node: E2E Test Results

    1 files      1 suites   22m 4s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit bf7f8e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Node: Unit Test Results

    2 262 files      2 262 suites   1h 23m 39s ⏱️
118 254 tests 118 220 ✔️ 34 💤 0
126 513 runs  126 479 ✔️ 34 💤 0

Results for commit bf7f8e9.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (6f96c20) 65.26% compared to head (bf7f8e9) 65.23%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9481      +/-   ##
=============================================
- Coverage      65.26%   65.23%   -0.04%     
- Complexity     29646    29652       +6     
=============================================
  Files           3260     3261       +1     
  Lines         124382   124463      +81     
  Branches       12896    12909      +13     
=============================================
+ Hits           81184    81192       +8     
- Misses         40121    40198      +77     
+ Partials        3077     3073       -4     
Files Coverage Δ
...ds/virtualmap/internal/merkle/VirtualRootNode.java 70.89% <0.00%> (ø)
...n/merkle/synchronization/LearningSynchronizer.java 0.00% <0.00%> (ø)
.../java/com/swirlds/merkledb/MerkleDbDataSource.java 73.00% <7.69%> (-4.88%) ⬇️
...ds/common/merkle/utility/MerkleTreeVisualizer.java 0.00% <0.00%> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Node: Integration Test Results

280 tests   280 ✔️  32m 55s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit bf7f8e9.

♻️ This comment has been updated with latest results.

cody-littley
cody-littley previously approved these changes Oct 26, 2023
imalygin
imalygin previously approved these changes Oct 31, 2023
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
imalygin
imalygin previously approved these changes Oct 31, 2023
jsync-swirlds
jsync-swirlds previously approved these changes Oct 31, 2023
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a little concerned with the catch structure, but should at least be safe.

Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
@artemananiev artemananiev merged commit 97ae8d9 into develop Nov 1, 2023
11 of 13 checks passed
@artemananiev artemananiev deleted the 09479-D-more-virtual-reconnect-logs branch November 1, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more logs to debug virtual map reconnect issues
4 participants