use Bytes.EMPTY instead of null to indicate empty keys/values #9519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
david-bakin-sl
requested changes
Oct 26, 2023
...ervice-impl/src/main/java/com/hedera/node/app/service/contract/impl/state/StorageAccess.java
Show resolved
Hide resolved
...edera-token-service/src/main/java/com/hedera/node/app/service/token/api/TokenServiceApi.java
Show resolved
Hide resolved
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #9519 +/- ##
=============================================
- Coverage 65.22% 65.22% -0.01%
+ Complexity 29559 29557 -2
=============================================
Files 3257 3257
Lines 123991 123995 +4
Branches 12812 12812
=============================================
- Hits 80877 80872 -5
- Misses 40061 40074 +13
+ Partials 3053 3049 -4
☔ View full report in Codecov by Sentry. |
tinker-michaelj
approved these changes
Oct 26, 2023
david-bakin-sl
approved these changes
Oct 26, 2023
lukelee-sl
added a commit
that referenced
this pull request
Oct 26, 2023
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
lukelee-sl
added a commit
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix broken HAPI tests by using Bytes.EMPTY instead of null
Related issue(s):
Fixes #9517
Notes for reviewer:
Checklist