New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable HollowAccountFinalizationSuite
#9535
Enable HollowAccountFinalizationSuite
#9535
Conversation
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <122310714+iwsimon@users.noreply.github.com>
Signed-off-by: Iris Simon <122310714+iwsimon@users.noreply.github.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
…ite' into 9362-HollowAccountFinalizationSuite
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <122310714+iwsimon@users.noreply.github.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
…-account-finalization Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #9535 +/- ##
==============================================
+ Coverage 0 64.73% +64.73%
- Complexity 0 29552 +29552
==============================================
Files 0 3261 +3261
Lines 0 124682 +124682
Branches 0 12935 +12935
==============================================
+ Hits 0 80716 +80716
- Misses 0 40925 +40925
- Partials 0 3041 +3041
☔ View full report in Codecov by Sentry. |
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
...ra-node/hedera-token-service/src/main/java/com/hedera/node/app/service/token/AliasUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...e/hedera-app/src/main/java/com/hedera/node/app/workflows/prehandle/PreHandleContextImpl.java
Outdated
Show resolved
Hide resolved
...e/hedera-app/src/main/java/com/hedera/node/app/workflows/prehandle/PreHandleContextImpl.java
Outdated
Show resolved
Hide resolved
...e/hedera-app/src/main/java/com/hedera/node/app/workflows/prehandle/PreHandleContextImpl.java
Outdated
Show resolved
Hide resolved
...e/hedera-app/src/main/java/com/hedera/node/app/workflows/prehandle/PreHandleContextImpl.java
Outdated
Show resolved
Hide resolved
…on' into 9362-D-hollow-account-finalization
.../hedera-app/src/main/java/com/hedera/node/app/workflows/prehandle/PreHandleWorkflowImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #9362
HollowAccountFinalizationSuite
Child Records Issues:
getTxnRecord
query.Hollow Account Finalization:
PreHandlContext.requiredHollowAccounts
which will be available in preHandleResult. Same for the payerCryptoUpdate
to update the key.requiredHollowAccounts
and finalize inHandleWorkflow
Misc:
MAX_CHILD_RECORDS_EXCEEDED
because we are adding ~700 child records for system account creation. Added an enum PrecedingTransactionCategory to add exception for the case. This will be an exception for genesis records and staking update synthetic transaction that happen every midnight.Key.PROTOBUF.parse()
causingBufferUnderFlowException
. Fixed it by catching it and also not parsing evmAliasesNOTE:
Two tests are not enabled
hollowAccountCompletionIsPersistedEvenIfTxnFails
,txnWith2CompletionsAndAnother2PrecedingChildRecords
because in mono-service the hollow account finalizations are committed even if the transaction fails. Do we want to retain that in mod-code ?