09543 d remove crypto class #9544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
lpetrovic05
requested review from
cody-littley,
alittley and
edward-swirldslabs
edward-swirldslabs
previously approved these changes
Oct 31, 2023
alittley
previously approved these changes
Oct 31, 2023
cody-littley
previously approved these changes
Oct 31, 2023
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
lpetrovic05
dismissed stale reviews from cody-littley, alittley, and edward-swirldslabs
via
00459a6
lpetrovic05
requested review from
cody-littley,
edward-swirldslabs and
alittley
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9544 +/- ##
==========================================
Coverage ? 65.24%
Complexity ? 29656
==========================================
Files ? 3259
Lines ? 124467
Branches ? 12912
==========================================
Hits ? 81208
Misses ? 40184
Partials ? 3075 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com> # Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/crypto/CryptoSetup.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/crypto/CryptoStatic.java
cody-littley
approved these changes
Nov 1, 2023
alittley
approved these changes
Nov 1, 2023
edward-swirldslabs
approved these changes
Nov 1, 2023
petreze
pushed a commit
that referenced
this pull request
Nov 2, 2023
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
imalygin
pushed a commit
that referenced
this pull request
Nov 13, 2023
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9543