Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests in ContractBurnHTSSuite #9572

Merged
merged 1 commit into from Oct 31, 2023

Conversation

agadzhalov
Copy link
Contributor

@agadzhalov agadzhalov commented Oct 30, 2023

Fixes two tests in ContractBurnHTSSuite. Only HapiTest annotation added

Related issue(s):

Fixes ##9435

Signed-off-by: Alexander Gadzhalov <alexander.gadzhalov@limechain.tech>
@agadzhalov agadzhalov requested review from a team as code owners October 30, 2023 14:58
@agadzhalov agadzhalov changed the title 09435L: fix tesst in ContractBurnHTSSuite Fix tests in ContractBurnHTSSuite Oct 30, 2023
@agadzhalov agadzhalov added Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization labels Oct 30, 2023
@agadzhalov agadzhalov self-assigned this Oct 30, 2023
@github-actions
Copy link

Node: E2E Test Results

    1 files      1 suites   19m 54s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit 1057c3b.

@github-actions
Copy link

Node: Unit Test Results

    2 259 files      2 259 suites   1h 43m 25s ⏱️
118 232 tests 118 198 ✔️ 34 💤 0
126 491 runs  126 457 ✔️ 34 💤 0

Results for commit 1057c3b.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c85c433) 0.00% compared to head (1057c3b) 65.24%.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #9572       +/-   ##
==============================================
+ Coverage           0   65.24%   +65.24%     
- Complexity         0    29596    +29596     
==============================================
  Files              0     3258     +3258     
  Lines              0   124187   +124187     
  Branches           0    12867    +12867     
==============================================
+ Hits               0    81022    +81022     
- Misses             0    40102    +40102     
- Partials           0     3063     +3063     

see 3258 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Node: Integration Test Results

280 tests   280 ✔️  32m 53s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 1057c3b.

@github-actions
Copy link

Node: HAPI Test Results

1 227 tests   753 ✔️  1h 10m 2s ⏱️
   165 suites  474 💤
   165 files        0

Results for commit 1057c3b.

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tinker-michaelj tinker-michaelj merged commit 0020819 into develop Oct 31, 2023
12 of 13 checks passed
@tinker-michaelj tinker-michaelj deleted the 09435-fix-burn-suite-tests branch October 31, 2023 12:43
imalygin pushed a commit that referenced this pull request Nov 13, 2023
Signed-off-by: Alexander Gadzhalov <alexander.gadzhalov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants