Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scheduled txn records queryable from ScheduleCreate payer account #9610

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

tinker-michaelj
Copy link
Collaborator

Description:
As above.

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link

github-actions bot commented Nov 1, 2023

Node: E2E Test Results

    1 files      1 suites   20m 51s ⏱️
310 tests 310 ✔️ 0 💤 0
328 runs  328 ✔️ 0 💤 0

Results for commit 045118f.

Copy link

github-actions bot commented Nov 1, 2023

Node: Unit Test Results

    2 220 files      2 220 suites   1h 38m 36s ⏱️
118 013 tests 117 979 ✔️ 34 💤 0
126 311 runs  126 277 ✔️ 34 💤 0

Results for commit 045118f.

Copy link

github-actions bot commented Nov 1, 2023

Node: HAPI Test Results

1 187 tests   381 ✔️  26m 55s ⏱️
   161 suites  806 💤
   161 files        0

Results for commit 045118f.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ddc7f2b) 65.26% compared to head (045118f) 65.26%.
Report is 1 commits behind head on release/0.43.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/0.43    #9610      +/-   ##
==================================================
- Coverage           65.26%   65.26%   -0.01%     
- Complexity          29218    29220       +2     
==================================================
  Files                3221     3221              
  Lines              122383   122385       +2     
  Branches            12525    12525              
==================================================
- Hits                79871    79870       -1     
- Misses              39554    39558       +4     
+ Partials             2958     2957       -1     
Files Coverage Δ
...service/mono/records/TxnAwareRecordsHistorian.java 97.90% <100.00%> (+0.02%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 1, 2023

Node: Integration Test Results

278 tests   278 ✔️  32m 33s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 045118f.

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@povolev15 povolev15 merged commit fbab206 into release/0.43 Nov 1, 2023
12 of 13 checks passed
@povolev15 povolev15 deleted the queryable-records-cleanup-r43 branch November 1, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants