Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added heartbeats to wiring framework. #9664

Merged
merged 4 commits into from Nov 7, 2023
Merged

Conversation

cody-littley
Copy link
Contributor

@cody-littley cody-littley commented Nov 3, 2023

Closes #9618

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley self-assigned this Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

Node: Unit Test Results

    2 273 files  +1      2 273 suites  +1   1h 26m 55s ⏱️ -14s
118 353 tests +5  118 319 ✔️ +5  34 💤 ±0  0 ±0 
126 614 runs  +5  126 580 ✔️ +5  34 💤 ±0  0 ±0 

Results for commit 3388b73. ± Comparison against base commit 450187e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 3, 2023

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   33m 0s ⏱️ +10s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 3388b73. ± Comparison against base commit 450187e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 3, 2023

Node: HAPI Test Results

1 242 tests  ±0   820 ✔️ +2   1h 22m 41s ⏱️ + 4m 20s
   165 suites ±0   422 💤  - 2 
   165 files   ±0       0 ±0 

Results for commit 3388b73. ± Comparison against base commit 450187e.

♻️ This comment has been updated with latest results.

Signed-off-by: Cody Littley <cody@swirldslabs.com>
Copy link

github-actions bot commented Nov 3, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 37s ⏱️ + 21m 37s
310 tests +309  310 ✔️ +310  0 💤 ±0  0  - 1 
332 runs  +331  332 ✔️ +332  0 💤 ±0  0  - 1 

Results for commit 3388b73. ± Comparison against base commit 450187e.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link
Contributor

@edward-swirldslabs edward-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving because the code is fairly benign. I'm not clear yet on the over all design that the heartbeat scheduler is working towards. Is there a diagram or plan to show this in context?

@cody-littley
Copy link
Contributor Author

@edward-swirldslabs

I'm approving because the code is fairly benign. I'm not clear yet on the over all design that the heartbeat scheduler is working towards. Is there a diagram or plan to show this in context?

I've not got a diagram, but there are intended uses for this feature. Currently there are several components that need to "do something" every so often even if they don't get new input. An example of this is the event creator. If it is unable to create an event due to rate limiting, we want it to try again at a later time. This heartbeat feature will allow us to keep using this same pattern with the new wiring framework.

Signed-off-by: Cody Littley <cody@swirldslabs.com>
jeromy-cannon
jeromy-cannon previously approved these changes Nov 7, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley merged commit 8de4c6b into develop Nov 7, 2023
14 of 15 checks passed
@cody-littley cody-littley deleted the 09618-heartbeats branch November 7, 2023 19:52
Ivo-Yankov pushed a commit that referenced this pull request Nov 9, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wiring framework: add ability to schedule reocurring tasks
4 participants