Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve logic via dependency migration test #9723

Merged
merged 2 commits into from Nov 7, 2023
Merged

Preserve logic via dependency migration test #9723

merged 2 commits into from Nov 7, 2023

Conversation

mhess-swl
Copy link
Member

@mhess-swl mhess-swl commented Nov 7, 2023 •
edited

The logic for inter-service dependencies during startup migrations is currently in the Hedera class, which isn't directly tested. This PR captures that logic in its own object, with a test to verify its behavior.

@mhess-swl
Preserve logic via dependency migration test
ca51a95 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@mhess-swl mhess-swl added the Modularization Issues or PRs related to modularization label Nov 7, 2023
@mhess-swl mhess-swl added this to the v0.45 milestone Nov 7, 2023
@mhess-swl mhess-swl self-assigned this Nov 7, 2023
@mhess-swl mhess-swl requested a review from a team as a code owner November 7, 2023 00:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited

Node: Unit Test Results

    2 275 files  +3      2 275 suites  +3   1h 27m 44s ⏱️ + 5m 28s
118 356 tests +8  118 322 ✔️ +8  34 💤 ±0  0 ❌ ±0 
126 617 runs  +8  126 583 ✔️ +8  34 💤 ±0  0 ❌ ±0 

Results for commit 3a15597. ± Comparison against base commit cce3566.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   20m 48s ⏱️ + 20m 48s
310 tests +309  310 ✔️ +310  0 💤 ±0  0 ❌  - 1 
332 runs  +331  332 ✔️ +332  0 💤 ±0  0 ❌  - 1 

Results for commit 3a15597. ± Comparison against base commit cce3566.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both. 
EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   33m 3s ⏱️ +11s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 3a15597. ± Comparison against base commit cce3566.

♻️ This comment has been updated with latest results.

david-bakin-sl
david-bakin-sl previously approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the usual questions and comments I have.

hedera-node/hedera-app/src/main/java/com/hedera/node/app/OrderedServiceMigrator.java Outdated Show resolved Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/OrderedServiceMigrator.java Show resolved Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/OrderedServiceMigrator.java Show resolved Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/OrderedServiceMigrator.java Outdated Show resolved Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/OrderedServiceMigrator.java Show resolved Hide resolved
...-node/hedera-app/src/test/java/com/hedera/node/app/state/merkle/DependencyMigrationTest.java Show resolved Hide resolved
...-node/hedera-app/src/test/java/com/hedera/node/app/state/merkle/DependencyMigrationTest.java Outdated Show resolved Hide resolved
...-node/hedera-app/src/test/java/com/hedera/node/app/state/merkle/DependencyMigrationTest.java Show resolved Hide resolved
...-node/hedera-app/src/test/java/com/hedera/node/app/state/merkle/DependencyMigrationTest.java Show resolved Hide resolved
...-node/hedera-app/src/test/java/com/hedera/node/app/state/merkle/DependencyMigrationTest.java Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited

Node: HAPI Test Results

1 242 tests  ±0   820 ✔️ +2   1h 23m 52s ⏱️ + 7m 56s
   165 suites ±0   422 💤  - 2 
   165 files   ±0       0 ❌ ±0 

Results for commit 3a15597. ± Comparison against base commit cce3566.

♻️ This comment has been updated with latest results.

@mhess-swl
Write ordering test and clarify
3a15597 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
david-bakin-sl
david-bakin-sl approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hedera-node/hedera-app/src/main/java/com/hedera/node/app/OrderedServiceMigrator.java Show resolved Hide resolved
...-node/hedera-app/src/test/java/com/hedera/node/app/state/merkle/DependencyMigrationTest.java Show resolved Hide resolved
tinker-michaelj
tinker-michaelj approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhess-swl mhess-swl merged commit 74cbf3f into develop Nov 7, 2023
14 of 15 checks passed
@mhess-swl mhess-swl deleted the migration-test branch November 7, 2023 22:07
Ivo-Yankov pushed a commit that referenced this pull request Nov 9, 2023
@mhess-swl @Ivo-Yankov
Preserve logic via dependency migration test (#9723)
02f9c04 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@mhess-swl @nickpoorman
Preserve logic via dependency migration test (#9723)
1260d01 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@david-bakin-sl david-bakin-sl david-bakin-sl approved these changes

@netopyr netopyr Awaiting requested review from netopyr netopyr is a code owner automatically assigned from hashgraph/hedera-base

Assignees

@mhess-swl mhess-swl

Labels
Modularization Issues or PRs related to modularization
Projects
Services Sprint Tracking
Archived in project
Milestone
v0.45
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhess-swl @tinker-michaelj @david-bakin-sl