Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ContractHTSSuite tests #9732

Merged
merged 5 commits into from Nov 13, 2023
Merged

Conversation

thenswan
Copy link
Contributor

@thenswan thenswan commented Nov 7, 2023

Description:
Fix ContractHTSSuite tests.

Related issue(s):
Fixes #9656

Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Copy link

github-actions bot commented Nov 7, 2023

Node: Unit Test Results

    2 277 files  ±0      2 277 suites  ±0   1h 28m 18s ⏱️ + 1m 31s
118 327 tests ±0  118 293 ✔️ ±0  34 💤 ±0  0 ±0 
126 588 runs  ±0  126 554 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 5a0ea1c. ± Comparison against base commit d9b49d5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 7, 2023

Node: E2E Test Results

    1 files      1 suites   21m 41s ⏱️
312 tests 312 ✔️ 0 💤 0
334 runs  334 ✔️ 0 💤 0

Results for commit 5a0ea1c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 7, 2023

Node: Integration Test Results

280 tests   280 ✔️  28m 25s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 5a0ea1c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 7, 2023

Node: HAPI Test Results

1 246 tests   868 ✔️  1h 28m 41s ⏱️
   166 suites  378 💤
   166 files        0

Results for commit 5a0ea1c.

♻️ This comment has been updated with latest results.

@MiroslavGatsanoga MiroslavGatsanoga added the Limechain Work planned for the LimeChain team label Nov 8, 2023
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TokenService and ScheduleService both dispatch txns so the HandleContext should not always set a ContractCallResult.

@thenswan thenswan requested a review from a team as a code owner November 9, 2023 14:49
@thenswan
Copy link
Contributor Author

thenswan commented Nov 9, 2023

@lukelee-sl @tinker-michaelj updated the PR with another option.

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah very nice, LGTM!

Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thenswan thenswan merged commit e894594 into develop Nov 13, 2023
14 of 15 checks passed
@thenswan thenswan deleted the 09650-fix-ContractHTSSuite-tests branch November 13, 2023 14:26
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ContractHTSSuite tests
6 participants