Add test to confirm preceding child record for HTS transfer #9735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgi-l95 <glazarov95@gmail.com> apply spotless Signed-off-by: georgi-l95 <glazarov95@gmail.com>
georgi-l95
force-pushed
the
9424-conditional-records-of-account-auto-creation-via-hts-classic-transfer-variants
branch
from
964f879
to
12996b8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #9735 +/- ##
=============================================
- Coverage 65.44% 65.43% -0.02%
+ Complexity 29983 29981 -2
=============================================
Files 3296 3296
Lines 125494 125558 +64
Branches 13017 13026 +9
=============================================
+ Hits 82130 82154 +24
- Misses 40238 40272 +34
- Partials 3126 3132 +6
☔ View full report in Codecov by Sentry. |
georgi-l95
deleted the
9424-conditional-records-of-account-auto-creation-via-hts-classic-transfer-variants
branch
Ivo-Yankov
pushed a commit
that referenced
this pull request
Nov 9, 2023
Added new test in the AutoCreationSuite which covers this new case and passes in mono codebase as well. With this change we cover this happy path from issue #9424: A "classic transfer" sending an NFT to an absent receiver address (outside long-zero range) generates a preceding child with a synthetic CryptoCreate and TransactionRecord identical that created by mono-service when it resolves to SUCCESS. Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
nickpoorman
pushed a commit
that referenced
this pull request
Nov 22, 2023
Added new test in the AutoCreationSuite which covers this new case and passes in mono codebase as well. With this change we cover this happy path from issue #9424: A "classic transfer" sending an NFT to an absent receiver address (outside long-zero range) generates a preceding child with a synthetic CryptoCreate and TransactionRecord identical that created by mono-service when it resolves to SUCCESS. Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added new test in the AutoCreationSuite which covers this new case and passes in mono codebase as well.
With this change we cover this happy path from issue #9424:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist