Auto-snapshot management #9739
Merged
Auto-snapshot management #9739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
iwsimon
reviewed
Nov 7, 2023
hedera-node/test-clients/record-snapshots/CryptoTransfer-SpecialAccountsBalanceCheck.json
Outdated
Show resolved
Hide resolved
iwsimon
reviewed
Nov 7, 2023
...st-clients/src/main/java/com/hedera/services/bdd/suites/crypto/AutoAccountCreationSuite.java
Outdated
Show resolved
Hide resolved
...st-clients/src/main/java/com/hedera/services/bdd/suites/crypto/AutoAccountCreationSuite.java
Outdated
Show resolved
Hide resolved
...t-clients/src/main/java/com/hedera/services/bdd/spec/utilops/records/AutoSnapshotModeOp.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Neeharika-Sompalli
previously approved these changes
Nov 7, 2023
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
tinker-michaelj
dismissed stale reviews from iwsimon and Neeharika-Sompalli
via
730c0c4
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Neeharika-Sompalli
approved these changes
Nov 7, 2023
Ivo-Yankov
pushed a commit
that referenced
this pull request
Nov 9, 2023
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
nickpoorman
pushed a commit
that referenced
this pull request
Nov 22, 2023
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
HapiSpecsnapshot matching #9697HapiSpecJSON snapshots into a single per-HapiSuitesnapshot.AutoSnapshotModeOpthat delegates to aSnapshotModeOpwith a mode determined by:HapiSpecto insert anAutoSnapshotModeOpat the start of the spec ifrecordStream.autoSnapshotManagement=true.CryptoTransferSuite.HapiCryptoTransfertransfer list construction deterministic by sorting.