Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove reconnect abort #9741

Merged
merged 10 commits into from Nov 13, 2023
Merged

remove reconnect abort #9741

merged 10 commits into from Nov 13, 2023

Conversation

lpetrovic05
Copy link
Member

@lpetrovic05 lpetrovic05 commented Nov 7, 2023 •
edited by poulok

closes #9450
closes #9678

@lpetrovic05
remove abort
9bddfff 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
dont learn while teaching
8e7deb2 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
spot
9670186 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05 lpetrovic05 added this to the v0.45 milestone Nov 7, 2023
@lpetrovic05 lpetrovic05 self-assigned this Nov 7, 2023
@lpetrovic05 lpetrovic05 requested review from a team as code owners November 7, 2023 15:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited

Node: Unit Test Results

    2 277 files  +  1      2 277 suites  +1   1h 25m 40s ⏱️ - 8m 0s
118 327 tests  - 36  118 293 ✔️  - 36  34 💤 ±0  0 ❌ ±0 
126 589 runs   - 35  126 555 ✔️  - 35  34 💤 ±0  0 ❌ ±0 

Results for commit ee495b5. ± Comparison against base commit abb9bb4.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 6s ⏱️ + 21m 6s
312 tests +311  312 ✔️ +312  0 💤 ±0  0 ❌  - 1 
334 runs  +333  334 ✔️ +334  0 💤 ±0  0 ❌  - 1 

Results for commit ee495b5. ± Comparison against base commit abb9bb4.

This pull request removes 1 and adds 312 tests. Note that renamed tests count towards both. 
EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

cody-littley
cody-littley previously approved these changes Nov 7, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 26s ⏱️ - 4m 42s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit ee495b5. ± Comparison against base commit abb9bb4.

♻️ This comment has been updated with latest results.

@lpetrovic05
test fix
0cfd98d 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
spot
10d3875 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited

Node: HAPI Test Results

1 246 tests  +4   867 ✔️ +42   1h 23m 36s ⏱️ + 5m 39s
   166 suites +1   379 💤  - 38 
   166 files   +1       0 ❌ ±  0 

Results for commit ee495b5. ± Comparison against base commit abb9bb4.

♻️ This comment has been updated with latest results.

@lpetrovic05 lpetrovic05 mentioned this pull request Nov 8, 2023
Closed
@lpetrovic05
Merge branch 'develop' into 09450-D-remove-reconnect-abort
90da9c0
@lpetrovic05
fix
0a02da7 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
fix tests
a6ee648 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
timo0
timo0 previously approved these changes Nov 10, 2023
View reviewed changes
artemananiev
artemananiev previously approved these changes Nov 10, 2023
View reviewed changes
@lpetrovic05
added unit test
af20be4 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
spot
ee495b5 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@poulok poulok merged commit 03614b6 into develop Nov 13, 2023
14 of 15 checks passed
@poulok poulok deleted the 09450-D-remove-reconnect-abort branch November 13, 2023 17:53
@alittley alittley mentioned this pull request Nov 13, 2023
Merged
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@lpetrovic05 @nickpoorman
remove reconnect abort (#9741)
2f549be 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imalygin imalygin imalygin approved these changes

@cody-littley cody-littley cody-littley approved these changes

@timo0 timo0 timo0 left review comments

@OlegMazurov OlegMazurov Awaiting requested review from OlegMazurov OlegMazurov is a code owner automatically assigned from hashgraph/platform-architects

@edward-swirldslabs edward-swirldslabs Awaiting requested review from edward-swirldslabs

@artemananiev artemananiev Awaiting requested review from artemananiev

Assignees

@lpetrovic05 lpetrovic05

Labels
None yet
Projects
None yet
Milestone
v0.45
Development

Successfully merging this pull request may close these issues.

Reconnect protocol violation causes havoc on the learner side. Reconnect abort is not thread safe
7 participants
@lpetrovic05 @timo0 @imalygin @artemananiev @cody-littley @edward-swirldslabs @poulok