Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9477: Direct memory / data source leak if teacher becomes inaccessible during reconnect #9780

Merged
merged 4 commits into from Nov 10, 2023
Merged

9477: Direct memory / data source leak if teacher becomes inaccessible during reconnect #9780

merged 4 commits into from Nov 10, 2023

Conversation

artemananiev
Copy link
Member

Fixes: #9477
Signed-off-by: Artem Ananev artem.ananev@swirldslabs.com

@artemananiev
9477: Direct memory / data source leak if teacher becomes inaccessibl…
61899be 
…e during reconnect

Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
@artemananiev artemananiev self-assigned this Nov 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited

Node: Unit Test Results

    2 277 files  +1      2 277 suites  +1   1h 25m 32s ⏱️ - 4m 52s
118 376 tests +9  118 342 ✔️ +9  34 💤 ±0  0 ❌ ±0 
126 637 runs  +9  126 603 ✔️ +9  34 💤 ±0  0 ❌ ±0 

Results for commit 009328a. ± Comparison against base commit a564b0a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   22m 3s ⏱️ + 22m 3s
310 tests +309  310 ✔️ +310  0 💤 ±0  0 ❌  - 1 
332 runs  +331  332 ✔️ +332  0 💤 ±0  0 ❌  - 1 

Results for commit 009328a. ± Comparison against base commit a564b0a.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both. 
EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 3s ⏱️ -30s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 009328a. ± Comparison against base commit a564b0a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited

Node: HAPI Test Results

1 246 tests  ±0   853 ✔️ ±0   1h 18m 57s ⏱️ - 14m 5s
   166 suites ±0   393 💤 ±0 
   166 files   ±0       0 ❌ ±0 

Results for commit eaa4c18. ± Comparison against base commit a564b0a.

♻️ This comment has been updated with latest results.

@artemananiev
Fixed data source files on disk leak
eaa4c18 
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
@artemananiev
Spotless
4649f2f 
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
@artemananiev artemananiev marked this pull request as ready for review November 9, 2023 21:11
@artemananiev artemananiev requested review from a team as code owners November 9, 2023 21:11
OlegMazurov
OlegMazurov previously approved these changes Nov 10, 2023
View reviewed changes
@artemananiev
Improved log message in VirtualRootNode.destroyNode()
009328a 
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
@artemananiev artemananiev merged commit 9203e0d into develop Nov 10, 2023
12 of 14 checks passed
@artemananiev artemananiev deleted the 09477-D-datasource-leak-on-reconnect branch November 10, 2023 02:35
ilko-iliev-lime pushed a commit that referenced this pull request Nov 10, 2023
@artemananiev @ilko-iliev-lime
9477: Direct memory / data source leak if teacher becomes inaccessibl…
55b24af 
…e during reconnect (#9780)

Fixes: #9477
Reviewed-by: Oleg Mazurov <oleg.mazurov@swirldslabs.com>
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
@artemananiev artemananiev mentioned this pull request Nov 10, 2023
Merged
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@artemananiev @nickpoorman
9477: Direct memory / data source leak if teacher becomes inaccessibl…
48561de 
…e during reconnect (#9780)

Fixes: #9477
Reviewed-by: Oleg Mazurov <oleg.mazurov@swirldslabs.com>
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegMazurov OlegMazurov OlegMazurov approved these changes

@imalygin imalygin Awaiting requested review from imalygin imalygin is a code owner automatically assigned from hashgraph/platform-data

Assignees

@artemananiev artemananiev

Labels
Platform Data Structures Platform Reconnect Platform Virtual Map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Direct memory / data source leak if teacher becomes inaccessible during reconnect
2 participants
@artemananiev @OlegMazurov