Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable tests from Issue2051spec #9791

Merged
merged 7 commits into from Nov 27, 2023

Conversation

Ivo-Yankov
Copy link
Contributor

Description:

  • Enables all tests from Issue2051spec
  • Closed previous PR due to some DCO issues

Related issue(s):

Fixes #8768

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@Ivo-Yankov Ivo-Yankov self-assigned this Nov 9, 2023
@Ivo-Yankov Ivo-Yankov added the Limechain Work planned for the LimeChain team label Nov 9, 2023
@Ivo-Yankov Ivo-Yankov marked this pull request as ready for review November 9, 2023 10:18
Copy link

github-actions bot commented Nov 9, 2023

Node: Unit Test Results

    2 283 files  ±0      2 283 suites  ±0   53m 36s ⏱️ + 5m 46s
118 366 tests +1  118 332 ✔️ +1  34 💤 ±0  0 ±0 
126 684 runs  +1  126 650 ✔️ +1  34 💤 ±0  0 ±0 

Results for commit df51052. ± Comparison against base commit 97b8abf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 9, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 17s ⏱️ + 23m 17s
310 tests +309  310 ✔️ +310  0 💤 ±0  0  - 1 
332 runs  +331  332 ✔️ +332  0 💤 ±0  0  - 1 

Results for commit df51052. ± Comparison against base commit 97b8abf.

This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 9, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 27s ⏱️ +13s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit df51052. ± Comparison against base commit 97b8abf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 9, 2023

Node: HAPI Test Results

1 245 tests   913 ✔️  1h 32m 26s ⏱️
   166 suites  332 💤
   166 files        0

Results for commit b95bbf7.

♻️ This comment has been updated with latest results.

@Ivo-Yankov Ivo-Yankov changed the title Enable tests from Issue2051spec fix: enable tests from Issue2051spec Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97b8abf) 65.27% compared to head (df51052) 65.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #9791   +/-   ##
==========================================
  Coverage      65.27%   65.27%           
- Complexity     30205    30207    +2     
==========================================
  Files           3329     3329           
  Lines         126937   126938    +1     
  Branches       13198    13200    +2     
==========================================
+ Hits           82853    82858    +5     
+ Misses         40876    40868    -8     
- Partials        3208     3212    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   25m 47s ⏱️ +32s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit df51052. ± Comparison against base commit 97b8abf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Token) Results

190 tests  ±0   188 ✔️ ±0   18m 10s ⏱️ +27s
  13 suites ±0       2 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit df51052. ± Comparison against base commit 97b8abf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   21m 4s ⏱️ + 4m 5s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit df51052. ± Comparison against base commit 97b8abf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 23, 2023

Node: HAPI Test (Misc) Results

418 tests  ±0   275 ✔️ +2   19m 54s ⏱️ - 1m 2s
  73 suites ±0   143 💤  - 2 
  73 files   ±0       0 ±0 

Results for commit df51052. ± Comparison against base commit 97b8abf.

♻️ This comment has been updated with latest results.

@Ivo-Yankov Ivo-Yankov added this to the v0.45 milestone Nov 26, 2023
Copy link

Node: HAPI Test (Smart Contract) Results

410 tests  ±0   318 ✔️ ±0   48m 20s ⏱️ + 5m 58s
  56 suites ±0     92 💤 ±0 
  56 files   ±0       0 ±0 

Results for commit df51052. ± Comparison against base commit 97b8abf.

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @Ivo-Yankov !

@tinker-michaelj tinker-michaelj merged commit abafe2b into develop Nov 27, 2023
24 of 25 checks passed
@tinker-michaelj tinker-michaelj deleted the 8768-resolve-issue2051spec branch November 27, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Resolve Issue2051Spec errors
3 participants