New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable tests from Issue2051spec #9791
Conversation
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Node: E2E Test Results 1 files ± 0 1 suites ±0 23m 17s ⏱️ + 23m 17s Results for commit df51052. ± Comparison against base commit 97b8abf. This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9791 +/- ##
==========================================
Coverage 65.27% 65.27%
- Complexity 30205 30207 +2
==========================================
Files 3329 3329
Lines 126937 126938 +1
Branches 13198 13200 +2
==========================================
+ Hits 82853 82858 +5
+ Misses 40876 40868 -8
- Partials 3208 3212 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty @Ivo-Yankov !
Description:
Related issue(s):
Fixes #8768
Notes for reviewer:
Checklist