New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements to exception handling and null checks #9813
Conversation
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one actual question.
...in/java/com/hedera/node/app/service/contract/impl/exec/operations/CustomCreateOperation.java
Show resolved
Hide resolved
...in/java/com/hedera/node/app/service/contract/impl/exec/operations/CustomCreateOperation.java
Show resolved
Hide resolved
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
…into improve-exception-hanlding-null-checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Description:
Handle specific exceptions when applicable and add a null check as appropriate.