Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

09665 9670 direct scheduler #9830

Merged
merged 20 commits into from Nov 14, 2023
Merged

09665 9670 direct scheduler #9830

merged 20 commits into from Nov 14, 2023

Conversation

cody-littley
Copy link
Contributor

Closes #9665

@cody-littley
Added heartbeats to wiring framework.
ee13cf3 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
New tests, fixed bugs.
c19c01b 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Added offer soldering.
d3b216e 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Added direct task scheduler.
bc15c50 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental progress fitting direct schedulers into the wiring model.
45e549d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental changes.
db3735b 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 09618-heartbeats
c282ebc 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch '09618-heartbeats' into 09670-9618-offer-solder
561483e 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested changes.
07f3760 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch '09670-9618-offer-solder' into 09665-9670-direct-scheduler
be02775 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental progress.
498f4b5 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 09665-9670-direct-scheduler
d7a5e64 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Minor changes.
83cccf3 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental progress.
cbafb57 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 09665-9670-direct-scheduler
bb6d0a0 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley added this to the v0.45 milestone Nov 10, 2023
@cody-littley cody-littley self-assigned this Nov 10, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited

Node: Unit Test Results

    2 278 files  +1      2 278 suites  +1   1h 27m 22s ⏱️ - 1m 47s
118 329 tests +3  118 295 ✔️ +3  34 💤 ±0  0 ❌ ±0 
126 593 runs  +5  126 559 ✔️ +5  34 💤 ±0  0 ❌ ±0 

Results for commit 06d221d. ± Comparison against base commit d7078a7.

♻️ This comment has been updated with latest results.

@cody-littley
Added unit tests.
dd07b4a 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley marked this pull request as ready for review November 10, 2023 20:00
@cody-littley cody-littley requested review from a team as code owners November 10, 2023 20:00
@cody-littley
Made suggested changes.
9829ff7 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 51s ⏱️ + 21m 51s
312 tests +311  312 ✔️ +312  0 💤 ±0  0 ❌  - 1 
334 runs  +333  334 ✔️ +334  0 💤 ±0  0 ❌  - 1 

Results for commit 06d221d. ± Comparison against base commit d7078a7.

This pull request removes 1 and adds 312 tests. Note that renamed tests count towards both. 
EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited

Node: HAPI Test Results

1 246 tests  ±0   871 ✔️ +1   1h 23m 45s ⏱️ - 4m 5s
   166 suites ±0   375 💤  - 1 
   166 files   ±0       0 ❌ ±0 

Results for commit 06d221d. ± Comparison against base commit d7078a7.

♻️ This comment has been updated with latest results.

@cody-littley cody-littley mentioned this pull request Nov 10, 2023
Merged
lpetrovic05
lpetrovic05 previously approved these changes Nov 13, 2023
View reviewed changes
@cody-littley
Made suggested change.
7565855 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 09665-9670-direct-scheduler
9dc66a6 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 35s ⏱️ +6s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 06d221d. ± Comparison against base commit d7078a7.

♻️ This comment has been updated with latest results.

alittley
alittley previously approved these changes Nov 13, 2023
View reviewed changes
...dk/swirlds-common/src/main/java/com/swirlds/common/wiring/builders/TaskSchedulerBuilder.java Outdated Show resolved Hide resolved
...m-sdk/swirlds-common/src/main/java/com/swirlds/common/wiring/builders/TaskSchedulerType.java Outdated Show resolved Hide resolved
...-sdk/swirlds-common/src/main/java/com/swirlds/common/wiring/model/DirectSchedulerChecks.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/wiring/model/ModelVertex.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/wiring/TaskScheduler.java Outdated Show resolved Hide resolved
...form-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/wiring/PlatformWiring.java Show resolved Hide resolved
@cody-littley
Made suggested changes.
06d221d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley merged commit f624c71 into develop Nov 14, 2023
14 of 15 checks passed
@cody-littley cody-littley deleted the 09665-9670-direct-scheduler branch November 14, 2023 14:57
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@cody-littley @nickpoorman
09665 9670 direct scheduler (#9830)
d61af70 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poulok poulok poulok left review comments

@alittley alittley alittley approved these changes

@lpetrovic05 lpetrovic05 lpetrovic05 left review comments

@edward-swirldslabs edward-swirldslabs Awaiting requested review from edward-swirldslabs

@hendrikebbers hendrikebbers Awaiting requested review from hendrikebbers hendrikebbers is a code owner automatically assigned from hashgraph/platform-base

@artemananiev artemananiev Awaiting requested review from artemananiev artemananiev is a code owner automatically assigned from hashgraph/platform-data

Assignees

@cody-littley cody-littley

Labels
None yet
Projects
None yet
Milestone
v0.45
Development

Successfully merging this pull request may close these issues.

Wiring Framework: Create direct task scheduler
4 participants
@cody-littley @lpetrovic05 @poulok @alittley