Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Consensus Roster Terminology #9834

Merged
merged 19 commits into from Dec 15, 2023
Merged

docs: Consensus Roster Terminology #9834

merged 19 commits into from Dec 15, 2023

Conversation

edward-swirldslabs
Copy link
Contributor

Description:
This documentation is provided to explain in detail how dynamic address books affects consensus and how the platform processes incoming events.

Related issue(s):

Fixes #9577

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   52m 10s ⏱️ +28s
118 445 tests ±0  118 411 ✔️ ±0  34 💤 ±0  0 ❌ ±0 
126 862 runs  ±0  126 828 ✔️ ±0  34 💤 ±0  0 ❌ ±0 

Results for commit 52766a6. ± Comparison against base commit 44bba9c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   22m 46s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs  333 ✔️ 0 💤 0 ❌

Results for commit 52766a6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Node: HAPI Test Results

1 246 tests   864 ✔️  1h 30m 39s ⏱️
   166 suites  382 💤
   166 files        0 ❌

Results for commit 60f9bd8.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Node: HAPI Test (Token) Results

189 tests   189 ✔️  17m 3s ⏱️
  13 suites      0 💤
  13 files        0 ❌

Results for commit 52766a6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Node: HAPI Test (Crypto) Results

211 tests   204 ✔️  17m 30s ⏱️
  22 suites      7 💤
  22 files        0 ❌

Results for commit 52766a6.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@44bba9c). Click here to learn what that means.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #9834   +/-   ##
==========================================
  Coverage           ?   62.98%           
  Complexity         ?    30813           
==========================================
  Files              ?     3363           
  Lines              ?   135415           
  Branches           ?    14090           
==========================================
  Hits               ?    85289           
  Misses             ?    46766           
  Partials           ?     3360

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Node: HAPI Test (Misc) Results

419 tests   - 1   320 ✔️ ±0   25m 1s ⏱️ +25s
  73 suites  - 1     99 💤  - 1 
  73 files    - 1       0 ❌ ±0 

Results for commit 1bd3497. ± Comparison against base commit 6353aeb.

This pull request removes 1 test. 
com.hedera.services.bdd.suites.regression.PrecompileMintThrottlingCheck ‑ precompileNftMintsAreLimitedByConsThrottle
This pull request skips 1 and un-skips 1 tests. 
com.hedera.services.bdd.suites.file.FileUpdateSuite ‑ optimisticSpecialFileUpdate

com.hedera.services.bdd.suites.regression.AddressAliasIdFuzzing ‑ addressAliasIdFuzzing

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Node: Integration Test Results

278 tests  ±0   278 ✔️ +1   26m 51s ⏱️ +5s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌  - 1 

Results for commit 52766a6. ± Comparison against base commit 44bba9c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  24m 40s ⏱️
  2 suites  12 💤
  2 files      0 ❌

Results for commit 52766a6.

♻️ This comment has been updated with latest results.

@edward-swirldslabs edward-swirldslabs changed the title Dynamic Address Book and Consensus Roster Documentation doc(DAB roster):Dynamic Address Book and Consensus Roster Documentation Dec 4, 2023
@edward-swirldslabs edward-swirldslabs changed the title doc(DAB roster):Dynamic Address Book and Consensus Roster Documentation docs(DAB roster):Dynamic Address Book and Consensus Roster Documentation Dec 4, 2023
@edward-swirldslabs edward-swirldslabs changed the title docs(DAB roster):Dynamic Address Book and Consensus Roster Documentation docs: Consensus Roster Terminology Dec 4, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Node: HAPI Test (Smart Contract) Results

398 tests  +1   360 ✔️ +4   45m 45s ⏱️ + 1m 53s
  55 suites ±0     38 💤  - 3 
  55 files   ±0       0 ❌ ±0 

Results for commit 1bd3497. ± Comparison against base commit 6353aeb.

♻️ This comment has been updated with latest results.

edward-swirldslabs and others added 4 commits December 8, 2023 13:12
@edward-swirldslabs @poulok
Update platform-sdk/docs/core/dynamic-address-book/DynamicAddressBook…
5a3d5f0 
…-PlatformDesign.md

Co-authored-by: Kelly Greco <82919061+poulok@users.noreply.github.com>
Signed-off-by: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com>
@edward-swirldslabs @poulok
Update platform-sdk/docs/core/dynamic-address-book/DynamicAddressBook…
5c4a390 
…-PlatformDesign.md

Co-authored-by: Kelly Greco <82919061+poulok@users.noreply.github.com>
Signed-off-by: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com>
@edward-swirldslabs @poulok
Update platform-sdk/docs/core/dynamic-address-book/DynamicAddressBook…
dfd4889 
…-PlatformDesign.md

Co-authored-by: Kelly Greco <82919061+poulok@users.noreply.github.com>
Signed-off-by: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com>
@edward-swirldslabs
code review changes.
18f4230 
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
alittley
alittley previously approved these changes Dec 8, 2023
View reviewed changes
@edward-swirldslabs
additional documentation on impact to gossip.
e701b29 
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
alittley
alittley previously approved these changes Dec 8, 2023
View reviewed changes
cody-littley
cody-littley previously approved these changes Dec 8, 2023
View reviewed changes
@edward-swirldslabs @poulok
Update platform-sdk/docs/core/dynamic-address-book/DynamicAddressBook…
98baab6 
…-PlatformDesign.md

Co-authored-by: Kelly Greco <82919061+poulok@users.noreply.github.com>
Signed-off-by: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com>
alittley
alittley previously approved these changes Dec 12, 2023
View reviewed changes
lpetrovic05
lpetrovic05 previously approved these changes Dec 14, 2023
View reviewed changes
@edward-swirldslabs @poulok
Update platform-sdk/docs/core/dynamic-address-book/DynamicAddressBook…
c654e80 
…-PlatformDesign.md

Co-authored-by: Kelly Greco <82919061+poulok@users.noreply.github.com>
Signed-off-by: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com>
@edward-swirldslabs @poulok
Update platform-sdk/docs/core/dynamic-address-book/DynamicAddressBook…
1bd3497 
…-PlatformDesign.md

Co-authored-by: Kelly Greco <82919061+poulok@users.noreply.github.com>
Signed-off-by: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com>
@edward-swirldslabs edward-swirldslabs merged commit e2c5d2a into develop Dec 15, 2023
34 of 35 checks passed
@edward-swirldslabs edward-swirldslabs deleted the 09577-DAB-Documentation branch December 15, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poulok poulok poulok approved these changes

@alittley alittley alittley approved these changes

@lpetrovic05 lpetrovic05 lpetrovic05 left review comments

@cody-littley cody-littley cody-littley left review comments

@anthony-swirldslabs anthony-swirldslabs Awaiting requested review from anthony-swirldslabs anthony-swirldslabs was automatically assigned from hashgraph/platform-data

@mxtartaglia-sl mxtartaglia-sl Awaiting requested review from mxtartaglia-sl mxtartaglia-sl was automatically assigned from hashgraph/platform-base

@OlegMazurov OlegMazurov Awaiting requested review from OlegMazurov OlegMazurov was automatically assigned from hashgraph/platform-architects

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create formal documentation for Dynamic Rosters
5 participants
@edward-swirldslabs @lpetrovic05 @cody-littley @poulok @alittley