Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky queue thread pause test #9866

Merged
merged 1 commit into from Nov 14, 2023
Merged

Conversation

cody-littley
Copy link
Contributor

Closes #9860

Signed-off-by: Cody Littley <cody@swirldslabs.com>
Copy link

Node: Unit Test Results

    2 277 files  ±0      2 277 suites  ±0   1h 25m 31s ⏱️ - 3m 38s
118 326 tests ±0  118 292 ✔️ ±0  34 💤 ±0  0 ±0 
126 588 runs  ±0  126 554 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit e1ff514. ± Comparison against base commit d7078a7.

Copy link

github-actions bot commented Nov 13, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 22s ⏱️ + 21m 22s
312 tests +311  312 ✔️ +312  0 💤 ±0  0  - 1 
334 runs  +333  334 ✔️ +334  0 💤 ±0  0  - 1 

Results for commit e1ff514. ± Comparison against base commit d7078a7.

This pull request removes 1 and adds 312 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 21s ⏱️ -8s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit e1ff514. ± Comparison against base commit d7078a7.

Copy link

Node: HAPI Test Results

1 246 tests  ±0   870 ✔️ ±0   1h 24m 25s ⏱️ - 3m 25s
   166 suites ±0   376 💤 ±0 
   166 files   ±0       0 ±0 

Results for commit e1ff514. ± Comparison against base commit d7078a7.

@cody-littley cody-littley merged commit de78508 into develop Nov 14, 2023
14 of 15 checks passed
@cody-littley cody-littley deleted the 09860-fix-flaky-pause-test branch November 14, 2023 15:00
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake in StoppableThreadTests
6 participants