Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all non-daemon threads are shutdown even if exec() throws #9871

Merged
merged 1 commit into from Nov 14, 2023
Merged

Ensure all non-daemon threads are shutdown even if exec() throws #9871

merged 1 commit into from Nov 14, 2023

Conversation

tinker-michaelj
Copy link
Collaborator

@tinker-michaelj tinker-michaelj commented Nov 13, 2023 •
edited

Description:

  • It is possible that recent "hanging" runs of recordStreamValidation() are due to an intermittent failure in a validator that itself runs HapiSpec's (e.g. the TokenReconciliationValidator) throwing an exception instead of returning a failed assertion from HapiSpecOperation.exec().
  • This would prevent the finalizer ExecutorService from being shut down, and lead to the test hanging forever.

@tinker-michaelj
Ensure all non-daemon threads are shutdown even if exec() throws an e…
498ec88 
…xception

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested review from a team as code owners November 13, 2023 23:09
Neeharika-Sompalli
Neeharika-Sompalli approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@github-actions GitHub Actions
Copy link

Node: Unit Test Results

    2 277 files  ±0      2 277 suites  ±0   1h 26m 52s ⏱️ + 2m 53s
118 326 tests ±0  118 292 ✔️ ±0  34 💤 ±0  0 ❌ ±0 
126 588 runs  ±0  126 554 ✔️ ±0  34 💤 ±0  0 ❌ ±0 

Results for commit 498ec88. ± Comparison against base commit 623fca5.

@github-actions GitHub Actions
Copy link

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 16s ⏱️ + 21m 16s
312 tests +311  312 ✔️ +312  0 💤 ±0  0 ❌  - 1 
334 runs  +333  334 ✔️ +334  0 💤 ±0  0 ❌  - 1 

Results for commit 498ec88. ± Comparison against base commit 623fca5.

This pull request removes 1 and adds 312 tests. Note that renamed tests count towards both. 
EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

@github-actions GitHub Actions
Copy link

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 27s ⏱️ +22s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 498ec88. ± Comparison against base commit 623fca5.

@github-actions GitHub Actions
Copy link

Node: HAPI Test Results

1 246 tests  ±0   871 ✔️ ±0   1h 24m 52s ⏱️ -49s
   166 suites ±0   375 💤 ±0 
   166 files   ±0       0 ❌ ±0 

Results for commit 498ec88. ± Comparison against base commit 623fca5.

@tinker-michaelj tinker-michaelj merged commit 464e027 into develop Nov 14, 2023
14 of 15 checks passed
@tinker-michaelj tinker-michaelj deleted the add-final-teardown branch November 14, 2023 01:16
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@tinker-michaelj @nickpoorman
Ensure all non-daemon threads are shutdown even if exec() throws (#…
f304b18 
…9871)

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

@rbair23 rbair23 Awaiting requested review from rbair23 rbair23 is a code owner automatically assigned from hashgraph/hedera-base

@povolev15 povolev15 Awaiting requested review from povolev15 povolev15 is a code owner automatically assigned from hashgraph/hedera-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tinker-michaelj @Neeharika-Sompalli